Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deduplicate identical mutations #141

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Birkbjo
Copy link
Member

@Birkbjo Birkbjo commented Sep 7, 2022

NOTE: This is a proof of concept. This does introduce bugs!

Eg. changing comments when offline, then changing value (or any other order) - will result in only the last action happening.
It's probably an easy fix once we use queryKeys properly, and can update individual values easily.

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-141--dhis2-data-entry.netlify.app

@HendrikThePendric
Copy link
Contributor

When you talk about identical mutations, you mean multiple mutations for the same data value right? You might want to change the PR title a bit because I don't think identical is very apt.

@Mohammer5
Copy link
Collaborator

By @Birkbjo:

will come back to this, but pretty low priority

@stale
Copy link

stale bot commented Apr 19, 2023

Hi!

Due to a lack of activity on this issue over time (180 days) it seems to be stale. If still relevant, please provide information that moves it forward, e.g. additional information, a pull request with suggested changes, or a reason to keep it open.

Any activity will keep it open, otherwise it will be closed automatically in 30 days. Thanks! 🤖

@stale stale bot added the stale label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants