fix: handle sections without data elements [DHIS2-15883] #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-359--dhis2-data-entry.netlify.app |
Mohammer5
approved these changes
Oct 2, 2023
dhis2-bot
added a commit
that referenced
this pull request
Oct 5, 2023
## [100.3.7](v100.3.6...v100.3.7) (2023-10-05) ### Bug Fixes * handle sections without data elements [DHIS2-15883] ([#359](#359)) ([83c062e](83c062e))
|
🎉 This PR is included in version 100.3.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ticket: https://dhis2.atlassian.net/jira/software/c/projects/DHIS2/issues/DHIS2-15883
This fixes an issue where the section would error out (and would crash) if a section had no data elements present. The problem was that the IndicatorTableBody component has logic that adds padding cells based on the number of data elements; when no data elements were present, the calculation was saying that the data elements in the section had -Infinity maxColumnsInSection)
** I also noticed that there was a problem adjusting the padding cells based on the totals being displayed. We were removing a padding cell when column totals were displayed (if you sum up by column, you get an additional row) and not when row totals were displayed (when you sum up by row, you get an additional column).
An example of this before the fix:
and after:
