fix: compute subtotals/totals for boolean types (DHIS2-9155) #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
commented
Aug 21, 2024
| @@ -744,7 +749,15 @@ export class PivotTableEngine { | |||
| totalCell.valueType = currentValueType | |||
| } | |||
|
|
|||
| if (dxDimension?.valueType === VALUE_TYPE_NUMBER) { | |||
| // compute subtotals and totals for all numeric and boolean value types | |||
There was a problem hiding this comment.
I had to keep the part above with the prev/current comparison because valueType can be of types other than numeric and boolean.
In that case, the total cell would not get the type, but always N/A if we simply check for numeric/boolean for assigning the last evaluated valueType in the loop and fallback to N/A otherwise.
This is to align with the recent change in the backend where values are returned with 2 decimals by default.
janhenrikoverland
approved these changes
Aug 26, 2024
|
Approved when tests are updated. |
dhis2-bot
added a commit
that referenced
this pull request
Aug 27, 2024
## [26.8.3](v26.8.2...v26.8.3) (2024-08-27) ### Bug Fixes * compute subtotals/totals for boolean types (DHIS2-9155) ([#1696](#1696)) ([3392d78](3392d78))
|
🎉 This PR is included in version 26.8.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-9155
Key features
Description
In aggregate analytics, boolean types can be summed up.
Prior to this PR, only dimensions with value type
NUMBERwere summed up when subtotals and/or totals options were enabled.After this PR, all numeric and boolean types will be summed up.
Screenshots
Before:
After:
