-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade @dhis2/ui-core to 4.1.1 and @dhis2/ui-widgets to 2.0.4 #198
Conversation
Deploy preview for dhis2-app-platform canceled. Built with commit a00d647 https://app.netlify.com/sites/dhis2-app-platform/deploys/5dee801c0bdb07000b9b6b52 |
This requires changes in: https://github.com/dhis2/app-platform/blob/master/shell/adapter/src/AuthBoundary/LoginModal.js the |
Good catch. |
I think we currently have two copies of We probably don't want to wait for it, but this would be a good use-case for #125 - it would probably have caught the Login Dialog failure due to |
shell/yarn.lock
Outdated
dependencies: | ||
prop-types "^15" | ||
|
||
"@dhis2/ui-core@3.12.0", "@dhis2/ui-core@^3.12.0": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are these versions of ui-core
coming from?
This was actually broken because @edoardo probably good to get in the habit of running the example app ( I also added |
# [3.0.0](v2.0.0...v3.0.0) (2019-12-09) ### Features * **deps:** upgrade @dhis2/ui-core to 4.1.1 and @dhis2/ui-widgets to 2.0.4 ([#198](#198)) ([07c2187](07c2187)) ### BREAKING CHANGES * **deps:** This will break applications which use the v3 API of `@dhis2/ui-core` components
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This is needed for DV where the new options UI uses features and fixes in
@dhis2/ui-core
introduced from version 4.BREAKING CHANGE: This will break applications expecting the
ui-core
v3 API