-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate a manifest, set PUBLIC_URL, and output a compliant zip #36
Conversation
Deploy preview for dhis2-app-platform ready! Built with commit f608185 |
Thanks to @awgaan for pointing out the deployment issue! |
Closes #26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also works on my machine. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might not matter so much but the build output also contain a superflous manifest.json with the "Create React App Sample" template, otherwise it also works for me with the webapp manifest, tested uploading the zip to an instance without any problems
Yeah, I thought about maybe overwriting that with the correct values but will remove it for now. |
Since this was approved by @varl and I addressed @erikarenhill 's comment I'm going to merge this after conflict resolution. Speak now if that's a problem! |
# [1.3.0](v1.2.3...v1.3.0) (2019-09-10) ### Features * generate a manifest, set PUBLIC_URL, and output a compliant zip ([#36](#36)) ([243454a](243454a))
This adds manifest generation to the build script, automatically sets the PUBLIC_URL passed to CRA so that it will be installable on a DHIS2 instance, and outputs a DHIS2-compliant zip archive of the production build to
./build/bundle/dhis2-{name}-{version}.zip
. This file can be uploaded directly to the App Management AppFuture enhancements:
activities.dhis
from the manifest/api/apps/My-Simple-Application/
rather than/apps/simple
or something equally pleasing to the eye