Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set dir to auto for new apps [LIBS-645] #865

Closed
wants to merge 1 commit into from

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Jul 22, 2024

See https://dhis2.atlassian.net/jira/software/c/projects/LIBS/issues/LIBS-645

This PR updates the configuration for newly initialized app to set dir: 'auto' so that by default apps will follow direction of user language, and hence display 'rtl' for Arabic, Urdu, etc.,

(After this is merged, https://github.com/dhis2/cli dependencies need to be updated)

@tomzemp tomzemp requested review from kabaros, KaiVandivier and a team July 22, 2024 14:16
@tomzemp tomzemp changed the title chore: set dir to auto for new apps chore: set dir to auto for new apps [LIBS-645] Jul 22, 2024
Copy link
Contributor

@KaiVandivier KaiVandivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would have breaking side effects for existing apps unfortunately, since this file is doing double-duty as the boilerplate file that's copied into new apps and as defaults that are read from here then applied to existing apps' config...

In the Vite for plugins branch though, I have some work to decouple the boilerplate and the config defaults (since applying an app entrypoint to an 'app' with only a plugin entrypoint makes things complicated) -- maybe we could point this one at alpha once that one is merged?

@tomzemp
Copy link
Member Author

tomzemp commented Jul 23, 2024

This would have breaking side effects for existing apps unfortunately, since this file is doing double-duty as the boilerplate file that's copied into new apps and as defaults that are read from here then applied to existing apps' config...

🤦‍♂️ Thanks.

Sounds good to address later if the vite changes will make this easier. I'm going to close for now 🙏

@tomzemp tomzemp closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants