Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter build logs to summarize moment locales #875

Closed
wants to merge 1 commit into from

Conversation

KaiVandivier
Copy link
Contributor

@KaiVandivier KaiVandivier commented Sep 2, 2024

Part of LIBS-635

Moment locales can end up being 135 lines of the build output -- this uses a custom logger for Vite to filter out those lines from the build output, and instead print a static summary of the moment locales. My assumption is that the moment locales won't really change, so the static summary is okay

It feels a little weird to override the Vite logger just to make this happen, so this is just a draft for now -- curious about input

If you're curious about how Vite does its logging, it looks like it uses a Rollup plugin to asses the build output and log it

Screenshot 2024-09-02 at 10 33 41 PM

@KaiVandivier KaiVandivier requested a review from a team September 2, 2024 20:41
@KaiVandivier
Copy link
Contributor Author

Decided against this to keep config simpler; can revisit in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant