fix: provide fallback api version [LIBS-683] #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabaros
approved these changes
Sep 23, 2024
dhis2-bot
added a commit
that referenced
this pull request
Sep 26, 2024
## [11.7.2](v11.7.1...v11.7.2) (2024-09-26) ### Bug Fixes * provide fallback api version [LIBS-683] ([#877](#877)) ([dc7bdfa](dc7bdfa))
|
🎉 This PR is included in version 11.7.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
dhis2-bot
added a commit
that referenced
this pull request
Nov 6, 2024
# [12.0.0-alpha.22](v12.0.0-alpha.21...v12.0.0-alpha.22) (2024-11-06) ### Bug Fixes * **publishVersion:** fix maxBodyLength when uploading to appHub ([c5abfd1](c5abfd1)) * add @babel/plugin-syntax-dynamic-import as a direct dependency ([#886](#886)) ([8c5ef0c](8c5ef0c)) * bump typescript version used in app shell ([8ebb2e8](8ebb2e8)) * provide fallback api version [LIBS-683] ([#877](#877)) ([dc7bdfa](dc7bdfa)) * update app-runtime dependency ([74a2165](74a2165))
|
🎉 This PR is included in version 12.0.0-alpha.22 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://dhis2.atlassian.net/browse/LIBS-683
This provides a safeguard for the login app to default to an api version if the api version is missing from api/loginConfig (see linked slack discussion on the thread).
I think it would be better to fix this on the backend to reliably be able to get and return that api version, but this helps prevent users not being able to log in while we refine how to improve consistency of api/loginConfig.