-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: v12 migration guide [LIBS-689] #884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, amazing guide. It looks very detailed and exhaustive.
I went through the guide with a very nit-picky and oblivious point-of-view, so I added a grand total of 21 comments and suggestions to make it easier to read and contextually make sense.
docs/migration/v12.md
Outdated
|
||
Here are some edge cases that were encountered when upgrading some apps with the new platform version: | ||
|
||
- There is a bug in Vite: importing from a directory, e.g. `‘./app/‘` where we would assume to get `./app/index.[jt]s`, can incorrectly resolve to a file with a similar name to the directory, e.g. `./App.tsx`. I see this as a bug with Vite, but as a workaround, file and dir names can be changed so they don’t conflict. Noticed in the Maintenance app beta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the Maintenance app example be linked/explained?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's probably best just to remove the mention, which I've done -- I think the rest of the comment is enough info. I've also removed similar "noticed in ___" mentions
Co-authored-by: Rene Pot <Topener@users.noreply.github.com>
Co-authored-by: Rene Pot <Topener@users.noreply.github.com>
Co-authored-by: Rene Pot <Topener@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Great work!
🎉 This PR is included in version 12.0.0-alpha.22 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 12.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
LIBS-689