Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove todos #891

Merged
merged 3 commits into from
Nov 7, 2024
Merged

chore: remove todos #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85479d7
chore: remove todos
kabaros Nov 7, 2024
667ec6a
chore: yarn
KaiVandivier Nov 7, 2024
3dc455e
Merge branch 'alpha' into chore/clean-todos
KaiVandivier Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cli/src/commands/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ const handler = async ({
pack: packAppOutput,
allowJsxInJs,
}) => {
// todo: we need to infer TypeScript in build command here similar to start
const paths = makePaths(cwd)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the build command works


mode = mode || (dev && 'development') || getNodeEnv() || 'production'
Expand Down
4 changes: 2 additions & 2 deletions cli/src/lib/paths.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ module.exports = (cwd = process.cwd(), { typeScript } = {}) => {
package: path.join(base, './package.json'),
yarnLock: findYarnLock(base, rootDirectory),
dotenv: path.join(base, './.env'),
config: path.join(base, './d2.config.js'), // TODO: double check this works
config: path.join(base, './d2.config.js'),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked it works

readme: path.join(base, './README.md'),
src: path.join(base, './src'),
public: path.join(base, './public'),
Expand All @@ -109,7 +109,7 @@ module.exports = (cwd = process.cwd(), { typeScript } = {}) => {
'./.d2/shell/src/plugin.index.jsx'
),
shellPluginEntrypoint: path.join(base, './.d2/shell/src/Plugin.jsx'),
// TODO: look at what to do with service-worker files whether to move to TS or not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this todo - it's a general question about whether we should move this whole repo to TypeScript, not the place for it in this PR

shellSrcServiceWorker: path.join(
base,
'./.d2/shell/src/service-worker.js'
Expand Down
Loading
Loading