Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address LIBS-723
Requires app-runtime changes (dhis2/app-runtime#1398)
width: auto
width: auto
, sowidth: 100%
is currently used -- margins don't work as expected in this case thoughwidth: auto
behavior could work with a<div>
around theiframe
, where thediv
uses theauto
width and the iframe useswidth: 100%
to match that sizeclassName
prop to<Plugin>
and the underlying iframecontentWidth
prop is used on thePlugin
component, then the width of the iframe will be based off the contents insideoffsetHeight
should measure a scrollbar heightI used patch-package to make it easier to test this out with app-runtime changes. I made 6 test cases in a component in the simple app to use:
height: 100%
Screen.Recording.2024-12-17.at.14.20.12.mov
To do and known issues
Before review:
div
around iframe to get default 'auto' width of divs (and iframe has width(/height?) 100% by default). Update: tried this out, and it makes the right behavior forwidth: auto
, but breaks other height behaviors. I don't think it's worth doingAfter review: