fix: handle async parentAlertsAdd #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
amcgee
approved these changes
Oct 9, 2024
|
Looks good, nice work! |
dhis2-bot
added a commit
that referenced
this pull request
Oct 9, 2024
## [3.11.1](v3.11.0...v3.11.1) (2024-10-09) ### Bug Fixes * handle alert returned async by parentAlertsAdd [LIBS-695] ([#1388](#1388)) ([9c989b2](9c989b2))
|
🎉 This PR is included in version 3.11.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
KaiVandivier
added a commit
that referenced
this pull request
Nov 25, 2024
* fix: handle async parentAlertsAdd * chore: fix comment
KaiVandivier
pushed a commit
that referenced
this pull request
Nov 25, 2024
dhis2-bot
added a commit
that referenced
this pull request
Nov 26, 2024
# [3.11.0-alpha.1](v3.10.4-alpha.1...v3.11.0-alpha.1) (2024-11-26) ### Bug Fixes * **cacheable-section:** synchronously flush recording state for UI consistency ([04bc604](04bc604)) * add endpoint to text plain matchers ([#1390](#1390)) ([de8fbec](de8fbec)) * expand FetchErrorDetails type ([#1389](#1389)) ([78ad0b3](78ad0b3)) * handle alert returned async by parentAlertsAdd [LIBS-695] ([#1388](#1388)) ([bba9c23](bba9c23)) * **cacheable-section:** stable references to avoid loops [LIBS-642] ([#1385](#1385)) ([31562e9](31562e9)) * update plugin sizing definition ([#1383](#1383)) ([38c09b9](38c09b9)) * **deps:** remove cli-app-scripts peer dep [LIBS-587] ([#1379](#1379)) ([9e22e88](9e22e88)) * **deps:** update cli-app-scripts for package/types race condition ([dee6795](dee6795)) ### Features * fixed dimensions efficiency ([#1386](#1386)) ([b56ad2d](b56ad2d)) * upgrade app-runtime React version to v18 ([#1387](#1387)) ([0e4a3d5](0e4a3d5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of LIBS-695 -- see also the accompanying PR in the app-platform, dhis2/app-platform#881
The change here handles the
parentAlertsAddfunction as asynchronous, since that's how post-robot handles functions passed between windows -- it also uses optional chaining to work with previous versions of the app-shell/Plugin LoaderIn the app-platform, there's just a small tweak to fix the
parentAlertsAddfunction by returning its result to the pluginScreenshots
successful-plugin-alerts.mov