fix(translations): [DHIS2-8998] missing translation #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonadomnisoru
changed the title
paschalidi
reviewed
Apr 20, 2021
There was a problem hiding this comment.
Hey good work on this. Only one comment on the code itself.
Also it has come to my attention that this one 👇 isnt really translated either, but I cant say if this is the right ticket to tackle it.
https://github.com/dhis2/capture-app/blob/master/src/core_modules/capture-core/components/Section/SectionHeaderSimple.component.js#L90
Other than that congrats on your first PR! 💯
paschalidi
approved these changes
Apr 20, 2021
simonadomnisoru
added a commit
that referenced
this pull request
Apr 21, 2021
* fix(translations): missing translation * fix(translations): no string * fix(translations): [DHIS2-8998] transalte more strings (cherry picked from commit 70b103e)
simonadomnisoru
added a commit
that referenced
this pull request
Apr 21, 2021
* fix(translations): missing translation * fix(translations): no string * fix(translations): [DHIS2-8998] transalte more strings (cherry picked from commit 70b103e)
simonadomnisoru
added a commit
that referenced
this pull request
Apr 21, 2021
* fix(translations): missing translation * fix(translations): no string * fix(translations): [DHIS2-8998] transalte more strings (cherry picked from commit 70b103e)
This was referenced Apr 21, 2021
dhis2-bot
added a commit
that referenced
this pull request
Apr 23, 2021
# [1.16.0](v1.15.1...v1.16.0) (2021-04-23) ### Bug Fixes * **translations:** [DHIS2-8998] translate strings ([b92350c](b92350c)) * correct app name and title specified in d2.config.js ([#1599](#1599)) ([f14cf01](f14cf01)) * DHIS2-10711 duplicated calls on search page ([#1572](#1572)) ([1360124](1360124)) * DHIS2-10712 duplicate checking on save only ([3665b76](3665b76)) * DHIS2-10713 when optionSet use EQ to filter ([#1624](#1624)) ([60b3764](60b3764)), closes [#1618](#1618) * DHIS2-10715 working lists default sorting ([e8280c3](e8280c3)) * DHIS2-10716 use code if option not found ([b80effd](b80effd)) * DHIS2-10723 ([#1622](#1622)) ([#1631](#1631)) ([fce7307](fce7307)) * DHIS2-10723 port on 2.36.0 ([#1630](#1630)) ([#1633](#1633)) ([b47524f](b47524f)), closes [#1622](#1622) * **translations:** [DHIS2-8998] missing translation ([#1617](#1617)) ([70b103e](70b103e)) * DHIS2-10738 pressing the back button after a fallback crashes app ([#1581](#1581)) ([6a75e9c](6a75e9c)) * DHIS2-10765 use form names ([8578891](8578891)) * DHIS2-10765 use form names ([ab74dc3](ab74dc3)) * DHIS2-10830 capture app will crash when program is missing some orgUnits ([#1600](#1600)) ([dc1a351](dc1a351)), closes [#1483](#1483) [#1532](#1532) [#1410](#1410) [#1536](#1536) [#1536](#1536) [#1588](#1588) [#1581](#1581) [#1580](#1580) [#1589](#1589) * DHIS2-9931 wording from Find to Search ([#1540](#1540)) ([0893bad](0893bad)) * TECH-542 Switch to new endpoint for org units ([dba014e](dba014e)) * the bug ([#1536](#1536)) ([043f4fd](043f4fd)) * the bug ([#1580](#1580)) ([c491a00](c491a00)) * **translations:** sync translations from transifex (v36) ([c017642](c017642)) ### Features * adds new icon for capture app ([#1534](#1534)) ([c700edd](c700edd)) * adds smaller icon ([#1544](#1544)) ([181a94c](181a94c)) * DHIS2-10218 stages and events widget - user can see a list of the different stages ([524dd92](524dd92))
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-8998
I added the missing i18n functions. The bug is quite old therefore many texts were already translated or changed. You can find the text changes summary in the Jira ticket.
The failed Cypress test is a known issuse