fix: DHIS2-10070 improves rules engine performance #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paschalidi
commented
Dec 7, 2020
| accValidFormValues[key] = isValid ? formValues[key] : null; | ||
| return accValidFormValues; | ||
| }, {}); | ||
| .filter(key => fieldsValidation[key]) |
There was a problem hiding this comment.
What used to happen before, is that we iterated over all the form values and returned null when there isn't a value. I return now elements that have values.
Please lets try to think if this will cause any problems in the long term.
There was a problem hiding this comment.
LGTM - I would test wether the default value assignment works as before. Check that a "Yes/No" data element left blank is evaluated to "No", or that a Numeric data element defaults to 0.
src/core_modules/capture-core/rules/actionsCreator/postProcessRulesEffects.js
Show resolved
Hide resolved
Bekkalizer
approved these changes
Dec 7, 2020
Bekkalizer
deleted the
cp/bugfixes/DHIS2-10070-performance-on-rules-engine
branch
|
🎉 This PR is included in version 1.3.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works on this ticket https://jira.dhis2.org/browse/DHIS2-10070.
Here is how much this would take in the previous version. If you would like me to explain in more detail how to get this view, please let me know and we can get into a call
This is the same action now
