Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport [DHIS2-10206] displays dialog when data has entered and user is exiting the page #1621

Conversation

paschalidi
Copy link
Contributor

@paschalidi paschalidi commented Apr 20, 2021

…iting the page (#1592)

* docs: Update README

* refactor: exports shared steps & fixes all tests (#1483)

* chore: only the fail true is on

* chore: fixes existing tests

* chore: reduces time

* chore: drops time more

* chore: adds 1000 ms

* chore: bring time to 20000

* chore: fixes new page

* chore: bring time down to 7000

* chore: time is 12000

* chore: timer is 14000

* chore: time equals 12000

* feat: extracts the functions

* chore: drops time to 6000

* chore: up to 12000

* chore: 15000

* chore: rebase and splits the shared steps

* chore: addmission date and missing steps

* chore: random and

* chore: fixes the tests

* chore: typo

* fix: program error bug (#1532)

* chore: solves the bug

* chore: covers with tests

* chore: adds missing test cases

* chore: removes the dhis2-capture- prefix (#1410)

* fix: the bug (#1536)

* chore(release): cut 1.15.1 [skip ci]

* the bug ([#1536](#1536)) ([fd2616f](fd2616f))

* chore: forward-ports the last two PRs  (#1588)

* fix: DHIS2-10738 pressing the back button after a fallback crashes app (#1581)

* chore: sets to false

* chore: covers bug case

* fix: the bug (#1580)

* chore: fix the rerun (#1589)

* chore: reverts

* chore: saves

* chore: fixes the bug

* chore: removes unused onCleanup

* chore: improves

* chore: cleans up and lints

* chore: fixes

* chore: imports from correct action

* chore: cleans up also on unmount

* chore: adds curr state

* chore: cleans up

* fix: the crash by removing only the correct entries on cleanUp

* chore: fixes the problem with the window

Co-authored-by: Joakim Storløkken Melseth <joakim@dhis2.org>
Co-authored-by: @dhis2-bot <apps@dhis2.org>
Co-authored-by: Joakim Storløkken Melseth <joakim.melseth@gmail.com>
@paschalidi paschalidi marked this pull request as draft April 20, 2021 10:42
@paschalidi paschalidi requested a review from JoakimSM April 20, 2021 11:04
@paschalidi paschalidi marked this pull request as ready for review April 20, 2021 13:06
@paschalidi paschalidi merged commit 3a3ac1b into patch/2.36.0 Apr 20, 2021
@paschalidi paschalidi deleted the cp/v36/cp/fix/DHIS2-10206-display-dialog-when-user-leaves-the-page branch April 20, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants