fix: [DHIS2-13346] assigned value #3087
Conversation
There was a problem hiding this comment.
I had no success with this solution when I tested it (used a rule to set a compulsory field when another field was filled in). Nevertheless, looking into it, we should approach this a bit differently.
Currently we save the result of a field validation in the Redux store when you exit a field ("onblur" for most of the field types). If you use the "assign" action in the rules engine, we presume that you fill in a valid value and that value is not validated (The better approach here would have been to validate on render. This is a big change however, one we should carefully consider the implications of before doing it)
My suggestion is to still presume that any value you set using the "assign" action in the rules engine is valid. There is a missing implementation detail here however. Any validation errors that existed prior to the assignment is not cleared. So, we will have to reset the relevant parts of the formsSectionsFieldsUI in the Redux store for that field. You should be able to add this logic in the reducer.
The formsSectionsFieldsUI is grouped by sections, so we will have to look in multiple groups. The relevant properties are: valid, errorMessage, errorData and validatingMessage (I think)
Let me know if you have questions.
...re_modules/capture-core/components/DataEntries/Enrollment/actions/enrollment.actionBatchs.js
Outdated
Show resolved
Hide resolved
|
🚀 Deployed on https://deploy-preview-3087--dhis2-capture.netlify.app |
There was a problem hiding this comment.
We can't use formBuilderId I believe. That is because the assignment can refer to a field in another section. We will have to look for the data element / tracked entity attribute in all sections that is starting with the formId.
Something like: Object.keys(state).filter(key => key.startsWith(formId))......
## [100.25.1](v100.25.0...v100.25.1) (2023-02-06) ### Bug Fixes * [DHIS2-13346] assigned value ([#3087](#3087)) ([41e5d27](41e5d27))
|
🎉 This PR is included in version 100.25.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.