-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [TECH-1654] upgrade cypress to v12 #3429
Conversation
…ress_v12 # Conflicts: # package.json
🚀 Deployed on https://deploy-preview-3429--dhis2-capture.netlify.app |
…ress_v12 # Conflicts: # package.json
Sounds awesome 😄 |
…ress_v12 # Conflicts: # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -1,5 +1,7 @@ | |||
Feature: Breaking the glass page | |||
|
|||
# TODO - Flaky tests should be fixed by TECH-1662 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you merge the PR, can you add this test and ticket to the Cypress tests wiki? Thanks!
Given you land on a main page with an invalid program id | ||
Then you should see error message | ||
# TODO - App crashes on invalid program id (DHIS2-16010) | ||
# Scenario: Main page > Url with invalid program id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same reminder about this scenario. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
🎉 This PR is included in version 100.43.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Ran into some performance issues, so decided trying to update to v12.
There were however some breaking changes, and because of this, VCS got really hard to track. Therefore, here are the main headers:
And
is deprecated by cucumber, but for now we import { defineStep as And } and it will work the same way