fix(loginByAPI): update loginByApi cypress command to support v42 #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-rita
force-pushed
the
DHIS2-17212/loginByAPI-command
branch
from
c03f7ca
to
df24f1a
Compare
d-rita
changed the title
d-rita
force-pushed
the
DHIS2-17212/loginByAPI-command
branch
from
df24f1a
to
37386ee
Compare
d-rita
changed the title
d-rita
changed the title
d-rita
force-pushed
the
DHIS2-17212/loginByAPI-command
branch
from
37386ee
to
3aff814
Compare
tomzemp
reviewed
May 16, 2024
| url: `${baseUrl}/api/loginConfig`, | ||
| method: 'GET', | ||
| }).then((response) => { | ||
| // Versions <= 41 |
There was a problem hiding this comment.
I think this comment should be // Versions >= 41
| }, | ||
| }) | ||
| } else { | ||
| // Versions >=40 |
tomzemp
approved these changes
May 16, 2024
dhis2-bot
added a commit
that referenced
this pull request
May 24, 2024
## [10.0.6](v10.0.5...v10.0.6) (2024-05-24) ### Bug Fixes * **loginByAPI:** update loginByApi cypress command to support v42 ([#402](#402)) ([6109ee5](6109ee5))
|
🎉 This PR is included in version 10.0.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
loginConfig, and if it exists (v41+), login happens via the new login endpoint.How to test:
To test, run
yarn cy:local