Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade @dhis2/cli-style to 5.0.2, don't auto-format code in pre-commit hook #208

Merged
merged 7 commits into from
Nov 26, 2019

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Nov 22, 2019

Upgrades @dhis2/cli-style to 5.0.2 which removes auto-formatting from the Husky pre-commit hooks. See dhis2/cli-style#153

Also upgrades @dhis2/cli-helpers-engine to 1.5.0 and removes redundant chalk dependencies

@amcgee amcgee requested review from varl and removed request for varl November 22, 2019 18:04
Copy link
Contributor

@varl varl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both PRs are released, this is good to proceed.

@amcgee amcgee changed the title fix: upgrade @dhis2/cli-helpers-engine to 1.5 and remove chalk fix: upgrade @dhis2/cli-style to 5.0.2, remove auto-format hooks Nov 25, 2019
@amcgee amcgee changed the title fix: upgrade @dhis2/cli-style to 5.0.2, remove auto-format hooks feat: upgrade @dhis2/cli-style to 5.0.2, don't auto-format code in pre-commit hook Nov 25, 2019
@amcgee amcgee marked this pull request as ready for review November 25, 2019 12:42
@amcgee amcgee merged commit c2f8eea into master Nov 26, 2019
@amcgee amcgee deleted the fix/helpers-engine-1.5 branch November 26, 2019 10:18
dhis2-bot added a commit that referenced this pull request Nov 26, 2019
# [2.7.0](v2.6.1...v2.7.0) (2019-11-26)

### Features

* upgrade @dhis2/cli-style to 5.0.2, don't auto-format code in pre-commit hook ([#208](#208)) ([c2f8eea](c2f8eea))
@dhis2-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants