feat: support custom plugin (DHIS2-17283) #3051
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This silences warnings in the console.
Link is rendering an a tag, and MenuItem does the same. Use a redirect on click instead (already done in the print submenu)
This hopefully has a better solution.
It should be enough to just use isParentCached for knowing when to start recording and removing the cache in the plugins.
This should fix some issues with plugin content not being visible.
This is to avoid the error boundary to show up for uncaught errors (failed to fetch a visualization) which interferes with Cypress testing.
|
🚀 Deployed on https://pr-3051.dashboard.netlify.dhis2.org |
* chore(deps): bump the security group with 3 updates Updates `ejs` from 3.1.8 to 3.1.10 - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.8...v3.1.10) Updates `tmpl` from 1.0.4 to 1.0.5 - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) Updates `word-wrap` from 1.2.3 to 1.2.5 - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect dependency-group: security - dependency-name: tmpl dependency-type: indirect dependency-group: security - dependency-name: word-wrap dependency-type: indirect dependency-group: security ... Signed-off-by: dependabot[bot] <support@github.com> * chore: break up command chain --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v3.0.0...v3.0.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jen Jones Arnesen <jennifer@dhis2.org>
…ponents' into feat/support-custom-plugin-DHIS2-17283
These are now reused for AppItem items too.
Don't render Plugin before knowing width and height.
Platform's plugin components rely on width and height in order to disable automatic resize.
Still not quite there. Currently the render fails with an error, but the updated snapshot makes the test pass.
| <IconWarning24 color={colors.grey500} /> | ||
| <span> | ||
| {i18n.t( | ||
| 'The plugin for rendering this item is not available' |
There was a problem hiding this comment.
Should we use a less technical word than "rendering" ? Actually, is it even useful to mention that a plugin is missing? Not sure about the second question. If we decide not say "plugin", we could still put that info in a console.warning.
"The plugin needed to display this item is not available."
"This item can't be displayed. Please contact your administrator"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-17283
NOTE: this branch is based on refactor/use-platform-plugin-components which needs to be merged first
Key features
Description
Dashboard app should have support for custom plugins built with the DHIS2 tooling.
This assumes the plugin uses the platform's components that provide the postRobot communication compatible with this version of dashboard app.
TODO
Known issues
Screenshots
Example with the Climate data app:
