chore: update postcss to fix node 17 error #2120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll close this PR as it's just a proof of concept. |
|
🚀 Deployed on https://pr-2120--dhis2-data-visualizer.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proof of concept for a bug reported here: https://dhis2.atlassian.net/browse/LIBS-334
Node 17 has deprecated a particular style of subpath folder mapping for module exports (nodejs/node#40121). This means that packages that still do this kind of remapping can cause our build to fail on node 17, as Martin reported in the above issue.
In Martin's issue, it was postcss that was causing the issue. Postcss has fixed their remapping style in this release: https://github.com/postcss/postcss/releases/tag/8.2.12. Before that they were using the deprecated exports style (see this commit for the change: postcss/postcss@96faacb).
This branch updates postcss to version 8.2.12, which fixes the failure for me locally. So it seems to me that that's indeed the cause of this issue. (note that the build still doesn't work, a new unrelated bug causes it to still fail).