feat: improve support for right-to-left languages in Data Visualiser #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tree (DHIS2-15000) (#3051)
Automatically merged.
Passing run #2868 ↗︎
Details:
Review all test suite changes for PR #3073 ↗︎ |
|||||||||||||||
kabaros
force-pushed
the
DHIS2-16778/visualiser-rtl-support
branch
from
699ef59
to
9091369
Compare
kabaros
force-pushed
the
DHIS2-16778/visualiser-rtl-support
branch
from
9091369
to
572b12d
Compare
|
🚀 Deployed on https://pr-3073.data-visualizer.netlify.dhis2.org |
kabaros
force-pushed
the
DHIS2-16778/visualiser-rtl-support
branch
from
572b12d
to
da932a3
Compare
kabaros
force-pushed
the
DHIS2-16778/visualiser-rtl-support
branch
from
da932a3
to
c16e61d
Compare
using css2logical tool
Data Visualizer App
|
||||||||||||||||||||||||||||
| Project |
Data Visualizer App
|
| Branch Review |
DHIS2-16778/visualiser-rtl-support
|
| Run status |
|
| Run duration | 10m 10s |
| Commit |
|
| Committer | Mozafar |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
741
|
| View all changes introduced in this branch ↗︎ | |
jenniferarnesen
approved these changes
Sep 2, 2024
jenniferarnesen
added
the
e2e record
This url doesn't work. Seems like netlify has changed their url format. This one works: |
jenniferarnesen
requested changes
Sep 26, 2024
|
Bug: |
|
Bug: wrong font Expected: |
|
Above reported bugs are now fixed |
jenniferarnesen
approved these changes
Sep 27, 2024
dhis2-bot
added a commit
that referenced
this pull request
Oct 7, 2024
# [100.8.0](v100.7.2...v100.8.0) (2024-10-07) ### Features * improve support for right-to-left languages ([#3073](#3073)) ([777b36d](777b36d)), closes [ui#1448](https://github.com/ui/issues/1448) [app-platform#825](https://github.com/app-platform/issues/825) [cli-style#464](https://github.com/cli-style/issues/464)
|
🎉 This PR is included in version 100.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-16778
Key features
cli-styleto a version that supports checking logical properties (and automatically converting physical to logical properties)Description
This PR implements better support for right-to-left languages in the app, by leveraging the use of logical CSS properties that are independent of language direction, rather than physical properties (i.e.
*-startinstead of-leftand*-endinstead*-right). Logical properties are widely supported now and they should become the default way for layout going-forward to ensure that we support RTL languages without extra development burden (which will be enforced byd2 style).Although the change set is big. It's mostly done automatically using
d2 style apply csswhich under the hood uses stylelint to enforce and apply the rules.The better support for RTL builds on top of previous work done in the platform, namely:
d2.configthat allows apps to declare they're ready to support RT. The platform changes also takes care of setting the correct direction and language for the header among other things: feat: add configurabledirfor language directions to app adapter [DHIS2-16480] app-platform#825Testing
Screenshots