feat: support new dashboard plugin architecture #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3082.data-visualizer.netlify.dhis2.org |
edoardo
changed the title
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
2 times, most recently
from
ac182a8 to
4b736b2
Compare
5 tasks
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
6822d49 to
86d232d
Compare
This has some fixes for the plugin.
Fixes the height issue with charts in dashboard.
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
86d232d to
39740ef
Compare
…rm-plugin-components
edoardo
changed the title
amcgee
reviewed
Nov 11, 2024
edoardo
added
the
e2e record
Data Visualizer App
|
||||||||||||||||||||||||||||
| Project |
Data Visualizer App
|
| Branch Review |
refactor/use-platform-plugin-components
|
| Run status |
|
| Run duration | 11m 12s |
| Commit |
|
| Committer | Edoardo Sabadelli |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
734
|
| View all changes introduced in this branch ↗︎ | |
…rm-plugin-components
This fixes the issue of DV plugins getting "stuck" in showing an error even after the cause is removed. If a dashboard filter is applied and causes a DV visualization to not have data, an error is shown in the plugin. When the filter was removed, the error was still shown.
edoardo
removed
the
e2e record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for DHIS2-17268
Requires dhis2/analytics#1672
Key features
Description
Generic components for plugins are available in
app-platformandapp-runtime.Analytics apps are currently having the same components replicated in each repo, a shared dashboard plugin wrapper has been added in
analytics.Known issues
Screenshots