Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade analytics to get pivot table truncated title feature [v39] [DHIS2-14827] #3280

Open
wants to merge 1 commit into
base: 39.x
Choose a base branch
from
Open

feat: upgrade analytics to get pivot table truncated title feature [v39] [DHIS2-14827] #3280

wants to merge 1 commit into from
+6 −6

Conversation

HendrikThePendric
Copy link
Contributor

@HendrikThePendric HendrikThePendric commented Nov 4, 2024 •
edited
Loading

Implements DHIS2-14827

This feature was implemented fully in @dhis2/analytics so all we need in DV is a version bump.

The PR against the dev branch (#2858) was closed because the analytics version there got bumped in another merged PR.

Key features

  1. Because we now truncate the title, long filters won't stretch the table horizontally anymore
  2. Once the title gets truncated a tooltip will be available for users to see the full title

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-3280.data-visualizer.netlify.dhis2.org

@cypress Cypress
Copy link

cypress bot commented Nov 4, 2024

Data Visualizer App    Run #2955

Run Properties:  status check passed Passed #2955  •  git commit 54f820a072 ℹ️: Merge d27d22c6163dc888c87a2b1526d7803c07910bdb into 220ade5f33ae1785b84be6cbd6ba...
Project Data Visualizer App
Branch Review feat/pivot-table-header-ellipsis-DHIS2-14827-v39
Run status status check passed Passed #2955
Run duration 10m 49s
Commit git commit 54f820a072 ℹ️: Merge d27d22c6163dc888c87a2b1526d7803c07910bdb into 220ade5f33ae1785b84be6cbd6ba...
Committer Hendrik de Graaf
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 627
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenniferarnesen jenniferarnesen jenniferarnesen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HendrikThePendric @dhis2-bot @jenniferarnesen