fix: upgrade to analytics with highcharts major version bump and address regressions #3288
+16
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue nr available
Requires: #3289
A short explanation why the above PR needs to get merged first:
HighCharts.Chart
, and the consequence of that is it should be treated the same as any other chart (specifically insrc/components/VisualizationPlugin/ChartPlugin.js
).ChartPlugin
does not include any special handling for the Single Value vis-type anymore. The most correct way to do so is to wait for fix: handle single value vis-type as highcharts chart instance #3289 to be merged to master and to bring the current branch up-to-date.Requires: dhis2/analytics#1728
At the time of writing we are using a GitHub commit URL for @dhis2/analytics, once the above PR is merged we can switch to a regular NPM version number.
Key features
Description
After the upgrade, we found an issue with the height of the chart: it would not fill the container but set the default 400px height. After discussing the problem with @edoardo we found that removing some code that we used to scale the chart fixed the issue. Quite likely, there was some interference between Highchart's auto-scaling and ours.
TODO
Known issues