Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade to analytics with highcharts major version bump and address regressions #3288

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

HendrikThePendric
Copy link
Contributor

@HendrikThePendric HendrikThePendric commented Nov 12, 2024

No issue nr available

Requires: #3289

A short explanation why the above PR needs to get merged first:

  • The upgrade to @dhis2/analytics v26.9.0 means the Singe Value vis-type is now a HighCharts.Chart, and the consequence of that is it should be treated the same as any other chart (specifically in src/components/VisualizationPlugin/ChartPlugin.js).
  • The current PR upgrades @dhis2/analytics to an even higher version, so before this is released we need to ensure that the ChartPlugin does not include any special handling for the Single Value vis-type anymore. The most correct way to do so is to wait for fix: handle single value vis-type as highcharts chart instance #3289 to be merged to master and to bring the current branch up-to-date.

Requires: dhis2/analytics#1728

At the time of writing we are using a GitHub commit URL for @dhis2/analytics, once the above PR is merged we can switch to a regular NPM version number.


Key features

  1. We are now using Highcharts v11

Description

After the upgrade, we found an issue with the height of the chart: it would not fill the container but set the default 400px height. After discussing the problem with @edoardo we found that removing some code that we used to scale the chart fixed the issue. Quite likely, there was some interference between Highchart's auto-scaling and ours.


TODO


Known issues

  • Highcharts 11 uses a new color scheme. It is not wildly different from the old one and looks quite nice. We need to decide if we just accept it, or if we want to revert to the old theme as illustrated here.

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Nov 12, 2024

🚀 Deployed on https://pr-3288.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify November 12, 2024 14:40 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 13, 2024 08:48 Inactive
@HendrikThePendric HendrikThePendric marked this pull request as draft November 13, 2024 09:23
@HendrikThePendric HendrikThePendric force-pushed the chore/upgrade-highcharts-in-analytics-to-v11 branch from 44f0b6e to 9f4ec91 Compare November 13, 2024 16:12
@dhis2-bot dhis2-bot temporarily deployed to netlify November 13, 2024 16:16 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants