Skip to content

Commit

Permalink
fix: fix running dhis war using maven jetty plugin (#9314)
Browse files Browse the repository at this point in the history
https://www.eclipse.org/jetty/javadoc/jetty-9/org/eclipse/jetty/server/NCSARequestLog.html
was deprecated and subsequently removed

Jetty 10 changed quite a lot regarding logging
jetty/jetty.project#4572

The Jetty libraries (both client and server) use SLF4J as logging APIs.
The only config we had in jetty-logging.properties is thus not needed
anymore.

There might be other settings we find have changed, that we need to adapt
  • Loading branch information
teleivo authored Nov 25, 2021
1 parent 9d4df49 commit 0bae148
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#

org.eclipse.jetty.util.log.class=org.eclipse.jetty.util.log.Slf4jLog
# File to add Jetty specific logging config https://www.eclipse.org/jetty/documentation/jetty-11/programming-guide/index.html#pg-troubleshooting-logging
7 changes: 0 additions & 7 deletions dhis-2/dhis-web/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,6 @@
<artifactId>jetty-maven-plugin</artifactId>
<version>${jetty.version}</version>
<configuration>
<requestLog implementation="org.eclipse.jetty.server.NCSARequestLog">
<filename>/tmp/request.log</filename>
<retainDays>2</retainDays>
<append>true</append>
<extended>false</extended>
<logTimeZone>GMT</logTimeZone>
</requestLog>
<systemProperties>
<systemProperty>
<name>org.eclipse.jetty.server.Request.maxFormContentSize</name>
Expand Down

0 comments on commit 0bae148

Please sign in to comment.