refactor: Add sort key to Table [DHIS2-16705] #19217
Merged
+117
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
@larshelge can we wait until later today to merge this PR, because I did something similar yesterday.
gnespolino
approved these changes
Nov 19, 2024
|
I guess we could merge now and then I can help with reconciling the DHIS2-16705 branch @luciano-fiandesio ? |
maikelarabori
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sort key list property to
Table. The sort key is applicable to Doris and ClickHouse analytics databases. The sort key is used to sort rows in tables, which is the primary approach for achieving performance in column oriented data warehouses.The sort key can be used in
DorisSqlBuilder#createTablemethod for thekeyclause, to provide a meaningful key for tables which don't have a primary key, such as the aggregate data value table and completeness table.