Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: JSON from and to JUON (JS URL Object Notation) #61

Merged
merged 8 commits into from
Jul 24, 2024

Conversation

jbee
Copy link
Collaborator

@jbee jbee commented Jun 29, 2024

Summary

Introduces the JS URL Object Notation. This is a JSON dialect or notation that is more URL friendly since its syntax uses characters permitted in URLs. This PR adds utilities to read JsonNodes (and therefore JsonValues) from JUON and also write JUON from objects.

In addition this fixes a bug in the JsonPath escape logic of keyOf that failed to escape a path containing a dot on special circumstances when it did contain curly brackets which would not be misunderstood as no valid closing bracket was present.

Automatic Testing

A new test case was added for the bugfix.
New tests were added for the new JUON features.

@jbee jbee self-assigned this Jun 29, 2024
@jbee jbee added the enhancement New feature or request label Jun 29, 2024
@jbee jbee changed the title feat: JUON parsing feat: JSON from and to JUON (JS URL Object Notation) Jul 1, 2024
@jbee jbee marked this pull request as ready for review July 24, 2024 14:17
@jbee jbee merged commit 283de32 into dhis2:main Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant