Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new dashboard plugin architecture #3232

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Jun 4, 2024

Part of the fix for: DHIS2-17268

Requires dhis2/analytics#1672


Key features

  1. use shared dashboard plugin wrapper

Description

Generic components for plugins are available in app-platform and app-runtime.
Analytics apps are currently having the same components replicated in each repo, a shared dashboard plugin wrapper has been added in analytics.


Known issues

  • an infinite loop happened and this seems to solve it, I'm not sure why and if this is a proper solution.

Screenshots

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 4, 2024

🚀 Deployed on https://pr-3232.maps.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify June 4, 2024 14:12 Inactive
@edoardo edoardo force-pushed the refactor/use-platform-plugin-components branch from 56b135d to 04d645c Compare July 3, 2024 10:10
@dhis2-bot dhis2-bot temporarily deployed to netlify July 3, 2024 10:31 Inactive
@edoardo edoardo changed the base branch from dev to master July 3, 2024 11:32
@edoardo edoardo force-pushed the refactor/use-platform-plugin-components branch from 26d68bb to 0330221 Compare July 11, 2024 09:12
@dhis2-bot dhis2-bot temporarily deployed to netlify July 11, 2024 09:16 Inactive
@edoardo edoardo force-pushed the refactor/use-platform-plugin-components branch from 0330221 to 258354c Compare August 2, 2024 10:13
First test if the app works without and create a new patch file if it
doesn't afterwards.
@dhis2-bot dhis2-bot temporarily deployed to netlify August 7, 2024 07:16 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 7, 2024 08:12 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 16, 2024 08:44 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 19, 2024 09:51 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 10, 2024 09:36 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 30, 2024 15:08 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 11, 2024 11:53 Inactive
@edoardo edoardo changed the title refactor: use shared dashboard plugin wrapper feat: support new dashboard plugin architecture Nov 11, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify November 15, 2024 14:21 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 15, 2024 15:15 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 18, 2024 13:00 Inactive
@edoardo edoardo marked this pull request as ready for review November 18, 2024 13:13
@edoardo edoardo requested a review from BRaimbault November 18, 2024 13:13
@dhis2-bot dhis2-bot temporarily deployed to netlify December 4, 2024 10:45 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 6, 2024 14:55 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 11, 2024 14:48 Inactive
@BRaimbault BRaimbault added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Dec 12, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify December 16, 2024 14:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants