Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pass issue number to upstream workflow #626

Merged
merged 1 commit into from
Jul 30, 2024
Merged

ci: pass issue number to upstream workflow #626

merged 1 commit into from
Jul 30, 2024

Conversation

ismay
Copy link
Contributor

@ismay ismay commented Jul 30, 2024

Documentation on this is sparse and confusing, and the workflow only works when present on the default branch, so unfortunately debugging this wf is a little trial and error. It seems that the issue event does not get passed to the upstream workflow, from what I can tell, so I'm passing it the issue number manually.

I'm also correcting the 'contains' logic with what should be the proper sequence of keys, even though it seems to contradict the docs. What we have now (with these changes) is what everyone is actually using, so that should be good.

@ismay ismay marked this pull request as ready for review July 30, 2024 08:05
@ismay ismay requested a review from a team as a code owner July 30, 2024 08:05
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-626--dhis2-scheduler.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify July 30, 2024 08:06 Inactive
@ismay ismay merged commit 0cb6877 into master Jul 30, 2024
8 checks passed
@ismay ismay deleted the fix-autoclosing branch July 30, 2024 09:16
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.6.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants