fix: update default props to JS default params #1598
Conversation
|
🚀 Deployed on https://pr-1598--dhis2-ui.netlify.app |
kabaros
force-pushed
the
update-props
branch
from
2d1474b to
5437911
Compare
|
Worked with @amcgee and found that the tests that were hanging were ones using Setting the prop default to a stable object reference fixed the loop issue, which was manually noticeable in storybook stories, so we updated other default props to similar stable objects -- running tests now to see if they work 🤞 Update: |
|
great find! thanks @amcgee @KaiVandivier |
## [9.11.5](v9.11.4...v9.11.5) (2024-09-26) ### Bug Fixes * update default props to JS default params ([#1598](#1598)) ([20e343f](20e343f))
# [10.0.0-alpha.7](v10.0.0-alpha.6...v10.0.0-alpha.7) (2024-11-14) ### Bug Fixes * **sharing-dialog:** add 'route' to SharingType type ([#1617](#1617)) ([1d9664a](1d9664a)) * revert "fix: select-field not showing in correct place" ([#1614](#1614)) ([c83de6b](c83de6b)) * **translations:** sync translations from transifex (master) ([491bf04](491bf04)) * update default props to JS default params ([#1598](#1598)) ([20e343f](20e343f)) ### Features * merge branch master into branch ([0577074](0577074)) * **icons:** add link-off icons ([e72be1e](e72be1e))
Implements LIBS-682
As we move to React 18 in platform as part ofhttps://github.com/dhis2/app-platform/pull/876, all our components and apps need to stop using defaultProps as these were deprecated and started generating a warning since React 18.3.
Most of this transformation was done using a codemod - the codemod is a bit brittle and tied to this project for now, but can be made more generic and incorporated in
d2 migrateas we test it in more projects.