Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes exeption if map return null or undefined #133

Merged
merged 1 commit into from
Apr 9, 2014
Merged

Fixes exeption if map return null or undefined #133

merged 1 commit into from
Apr 9, 2014

Conversation

nibrag
Copy link
Contributor

@nibrag nibrag commented Apr 8, 2014

var Foo = Backbone.AssociatedModel.extend({});

        var Bar = Backbone.AssociatedModel.extend({
            relations: [
                {
                    type: Backbone.One,
                    key: 'rel',
                    relatedModel: Foo,
                    map: function(m) {
                        if(m.rel.test == '') return null;
                        return m;
                    }
                }
            ],
        });

        var bar = new Bar({rel: {'test': ''}});

this code raised exeption:

Uncaught TypeError: Cannot call method 'hasOwnProperty' of null backbone-associations.js:314
(anonymous function) backbone-associations.js:314
_.each._.forEach underscore.js:79
Backbone.AssociatedModel.Backbone.Associations.AssociatedModel.BackboneModel.extend._setAttr backbone-associations.js:259
Backbone.AssociatedModel.Backbone.Associations.AssociatedModel.BackboneModel.extend._set backbone-associations.js:233
Backbone.AssociatedModel.Backbone.Associations.AssociatedModel.BackboneModel.extend.set backbone-associations.js:197
Backbone.Model backbone-min.js:266
Backbone.AssociatedModel.Backbone.Associations.AssociatedModel.BackboneModel.extend.constructor backbone-associations.js:115
Backbone.AssociatedModel.extend._.extend.constructor notified-model.js:7
child backbone-min.js:1583
_.extend._prepareModel backbone-min.js:929
_.extend.set backbone-min.js:720
_.each.CollectionProto.(anonymous function) backbone-associations.js:795
_.extend.add backbone-min.js:652
_.extend.reset backbone-min.js:783
_.each.CollectionProto.(anonymous function) backbone-associations.js:795
_.extend.fetch.options.success backbone-min.js:879
x.Callbacks.c jquery-1.10.1.min.js:745
x.Callbacks.p.fireWith jquery-1.10.1.min.js:779
k jquery-1.10.1.min.js:1872
x.ajaxTransport.send.r

jdkanani added a commit that referenced this pull request Apr 9, 2014
Fixes exeption if `map` return null or undefined
@jdkanani jdkanani merged commit 05f1350 into dhruvaray:master Apr 9, 2014
@dhruvaray dhruvaray added the bug label May 14, 2014
dhruvaray added a commit that referenced this pull request Jun 28, 2014
@dhruvaray
Copy link
Owner

This fix does not terminate the recursion. Let me know if you have any issues...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants