Error when trying to change todo status

[majutsushi]

In Vim 8.0.49, if I try to use the cit binding to change the TODO status of a line, I get this error after pressing a key to select the status to change to:

Error detected while processing function dotoo#change_todo:
line    4:
E718: Funcref required
line    5:
E718: Funcref required

Unrelated, looking at the source of that function made me notice that it would be good to add the abort modifier to all of the functions so that they stop executing after the first error (see :h :func-abort).

[dhruvasagar]

Hey, thanks for the suggestion I will use abort more. This error seems to indicate that dotoo#get_headline() & dotoo#parser#headline#get() perhaps failed to find the headline and returned nothing. So it could mean that either the file which you are trying to manipulate was somehow not parsed or parsed incorrectly. Mind digging a bit deeper ?

[majutsushi]

I did a quick test, and discovered that if I use the mapping on a headline (i.e. one with one or more stars at the beginning) it works, but if I use it on any other line it fails with the above error. So if todo markers are not supported on those lines it should probably either ignore them or give a meaningful warning. By the way, during the testing I came across another issue: If I change a headline without saving the file, and then use the todo status mapping, it works on the saved file and so discards the unsaved changes. This could probably be handled by getting the line content with the 'getline()' function instead of whatever it is doing at the moment.

[dhruvasagar]

Hi,

Thanks for looking into this, I believe that is by design, I will try to make sure that when you use this functionality it doesn't give errors when using on non-headline lines.

As far as working with unsaved files go I will have another look, by design since we do a lot of manipulations to files, it is designed to work with unsaved files and tries to read files from buffer, as opposed to reading from the file system so it should in theory work, but there is also a caching layer in play and if files are changed outside of vim there may be gaps and the caches may become invalidated without the plugins knowledge.

[lgalke]

Hey there,
I experienced the same issue from time to time (exactly the same error messages as above). But, at least for me, it is also raised when I type cit inside the headline. From my experience, I assume that the problem is somewhat related to the timestamp in the headline. I paste the malfunctioning file exactly as is here:

* CityX [2017-01-24 Tue 09:00]

** BusinessTrip [2017-01-23 Mon 11:13]
   - Hin- und Rückfahrt: 123,45€

EDIT: I also tried switching CityX with the [datetime] block but that didnt help. However, removing the time and retaining the date did help.

EDIT2: And yes, at some point I also notice that by applying cit, that headlines are rewritten by outdated text or text from other locations in the file, even if I save the file before.