Buildkite support #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
|
@woodruffw @di I've run this on a BuildKite and can verify that it works against the staging instance. |
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
woodruffw
reviewed
Mar 9, 2023
Comment on lines
+216
to
+231
| # Now query the agent for a token. | ||
| # | ||
| # NOTE(alex): We're silencing `bandit` here. The reasoning for ignoring each | ||
| # test are as follows. | ||
| # | ||
| # B603: This is complaining about invoking an external executable. However, | ||
| # there doesn't seem to be any way to do this that satisfies `bandit` so I | ||
| # think we need to ignore this. | ||
| # More context at: | ||
| # https://github.com/PyCQA/bandit/issues/333 | ||
| # | ||
| # B607: This is complaining about invoking an external executable without | ||
| # providing an absolute path (we just refer to whatever `buildkite-agent`) | ||
| # is in the `PATH`. For a Buildkite agent, there's no guarantee where the | ||
| # `buildkite-agent` is installed so again, I don't think there's anything | ||
| # we can do about this. |
There was a problem hiding this comment.
Thanks for the detailed comment! Silencing these warnings looks good to me.
di
reviewed
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.