-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial split from sigstore-python
#4
Conversation
8067d0c
to
0026d15
Compare
entrypoint: python | ||
args: ["-m", "id", "--audience", "throwaway"] | ||
env: | ||
- "GOOGLE_SERVICE_ACCOUNT_NAME=sigstore-python-test@projectsigstore.iam.gserviceaccount.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a non-issue, but does it make sense to have a different Google service account here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for the reminder, I need to setup these tests to actually run.
readme = "README.md" | ||
license = { file = "LICENSE" } | ||
authors = [ | ||
{ name = "Sigstore Authors", email = "sigstore-dev@googlegroups.com" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably needs updating as well.
Going to merge this so I can test the GCB integration, will address comments in follow-up PRs. |
No description provided.