feat: state changes for feed item row #1002

sanjeevdialpad · 2023-05-30T17:35:51Z

State changes for Feed item Row

🛠️ Type Of Change

Fix
Feature
Refactoring
Documentation

📖 Description

Feed item row should define state for normal, searched and error. Further have a boolean property for fade that transitions the background color back to normal.

💡 Context

📝 Checklist

I have reviewed my changes
I have added tests
I have added all relevant documentation
I have validated components with a screen reader
I have validated components keyboard navigation
I have considered the performance impact of my change
I have checked that my change did not significantly increase bundle size
I am exporting any new components or constants in the index.js in the component directory
I am exporting any new components or constants in the index.js in the root

🔮 Next Steps

Unit tests in a separate PR

📷 Screenshots / GIFs

🔗 Sources

Figma: https://www.figma.com/file/GJiRmWORmDi0zxLJfwn8yp/DP-2.0---Conversation-View?type=design&node-id=3-20503&t=gpfjBAhBBdIXICDB-0

github-actions · 2023-05-30T17:36:03Z

Thanks for contributing to Dialtone Vue! Please read below for some important info regarding Vue 3 compatibility.

Currently we need to maintain two branches in Dialtone Vue, one for Vue 2, one for Vue 3.

This means you must create two PRs for every feature change you make. One into staging and one into staging-vue3.

Many times the change you have made in Vue 2 will be identical to the change you need to make in Vue 3. To make this easier we have made a script that can copy your changes from this branch to a new branch off of staging-vue3 suffixed with -vue3.

run ./copy_pr_vue3.sh from the root dialtone-vue directory.

Once the new branch is created, you will need to look at your code to make sure it still makes sense and test that your changes all work in vue 3. If everything is good you can push it and create a PR into staging-vue3.

It is a required check for every PR to have a corresponding branch called yourbranch-vue3 so that we do not forget to do it. In the special case that you need to make a change to vue2 without making it in vue3, you can set the label vue2-only on this PR.

I got "commit SHA is a merge but no -m option was given."

This happens if there are merge commits in your branch. It's no problem, you can simply skip them with git cherry-pick --skip. We don't want to copy merge commits to the Vue 3 branch.

What if I make more changes to my vue 2 branch after running ./copy_pr_vue3.sh?

You can copy these to the existing -vue3 branch by running the script with a git SHA param like so:

./copy_pr_vue3.sh 2a78db7

where 2a78db7 is the last commit from your branch that was copied to the other branch (all commits after this will be copied)

If it's just one or two commits, you may prefer to just manually use git cherry-pick which will work fine as well.

What if I get a conflict?

It's possible to get a conflict when running copy_pr_vue3.sh as there are differences in Vue 2 and Vue 3 code. If this happens you can manually fix the conflict, commit it and do git cherry-pick --continue.

github-actions · 2023-05-30T17:37:49Z

✔️ Deploy Preview ready!
😎 Browse the preview: https://vue.dialpad.design/deploy-previews/pr-1002/
🔨 If you experience an SSL issue then wait 2 minutes and try again.

recipes/conversation_view/feed_item_row/feed_item_row.vue

braddialpad · 2023-05-30T18:39:46Z

recipes/conversation_view/feed_item_row/feed_item_row.vue

+    /**
+     * Whether to fade the background color to default
+     */
+    fade: {
+      type: Boolean,
+      default: false,
+    },


I am curious how this would actually be triggered on the product side, since this just triggers on mount is there a case when we might not want to fade this immediately, but rather when the specific feed item row becomes visible? After it has initially faded, there is no possible way to fade it again right? is there any case now or possibly in the future where we would need to do this?

The other possible way which might allow for more control is to just create a function that can be called via a component ref. We use this method sometimes for things like setFocus() and such. I think it makes a bit more sense for a "single trigger" type thing such as this.

so i removed setTimeout since now it uses method to do the fade.

braddialpad · 2023-05-30T18:42:39Z

recipes/conversation_view/feed_item_row/feed_item_row.vue

+    setTimeout(() => {
+      this.$refs.FeedItemRef.$el.classList.remove(FEED_ROW_STATE_BACKGROUND_COLOR[this.state]);
+    }, 1500);


I'd recommend storing the return value in a data property and calling clearTimeout on it when the component unmounts otherwise it may be possible to get an error if the timer hasn't triggered yet when the component unmounts.

Hmm
I put a true value on fade prop and then 1500ms later it says:
Failed to execute 'remove' on 'DOMTokenList': The token provided must not be empty.

How I can test this? did I miss sth?

i didnt handle the case where state is normal, then no background is applied and hence no fade can occur. Will change sorry!

github-actions · 2023-06-02T19:05:36Z

✔️ Deploy Preview ready!
😎 Browse the preview: https://vue.dialpad.design/deploy-previews/pr-1002/
🔨 If you experience an SSL issue then wait 2 minutes and try again.

iropolo

Thanks for the update 🚀 ! LGTM

github-actions · 2023-06-05T18:38:24Z

✔️ Deploy Preview ready!
😎 Browse the preview: https://vue.dialpad.design/deploy-previews/pr-1002/
🔨 If you experience an SSL issue then wait 2 minutes and try again.

braddialpad

Thanks!

github-actions · 2023-06-05T20:25:53Z

✔️ Deploy Preview ready!
😎 Browse the preview: https://vue.dialpad.design/deploy-previews/pr-1002/
🔨 If you experience an SSL issue then wait 2 minutes and try again.

# [2.86.0](v2.85.1...v2.86.0) (2023-06-13) ### Bug Fixes * add placeholder text for richtexteditor ([#1004](#1004)) ([8f7b50d](8f7b50d)) * **Contact Row, Group Row, General Row:** null on description ([#1013](#1013)) ([39fdd11](39fdd11)) * DIALTONE-1089 pagination muted clear button error ([f2c79ac](f2c79ac)) * **Modal:** secondary action button kind ([#1011](#1011)) ([3f0717d](3f0717d)) * revert [DIALTONE-1089] fix: pagination muted clear button error ([b234496](b234496)) ### Documentation * fix broken story ([bfcd04b](bfcd04b)) ### Features * **Modal:** show event and initial-focus-element ([#1009](#1009)) ([f4109a7](f4109a7)) * **Rich Text Editor:** link extension ([#991](#991)) ([9612c7c](9612c7c)) * **Rich Text Editor:** tests for rich text editor link extension and utils ([#1001](#1001)) ([203fda4](203fda4)) * state changes for feed item row ([#1002](#1002)) ([5838862](5838862))

github-actions · 2023-06-13T22:41:40Z

🎉 This PR is included in version 2.86.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [2.84.0-beta.1](v2.83.3...v2.84.0-beta.1) (2023-06-14) ### Bug Fixes * add placeholder text for richtexteditor ([#1004](#1004)) ([19e1ef9](19e1ef9)) * change to fnv algo ([f6e01a1](f6e01a1)) * component documentation link class ([#985](#985)) ([95c178c](95c178c)) * DIALTONE-1089 pagination muted clear button error ([4bd3170](4bd3170)) * **Keyboard Shortcut:** inverted border color ([b68387c](b68387c)) * **Leftbar General Row:** add href for focusability ([#994](#994)) ([73bc4e0](73bc4e0)) * missing migrations ([7483e16](7483e16)) * **Modal:** secondary action button kind ([#1011](#1011)) ([f899cb8](f899cb8)) * revert [DIALTONE-1089] fix: pagination muted clear button error ([f43066c](f43066c)) * set node engine minimum to 12.20 ([#988](#988)) ([a53db3c](a53db3c)) * update dialtone-icons ([9a8c31a](9a8c31a)) ### Features * **Avatar:** update to flat colors ([#982](#982)) ([469fe05](469fe05)) * **Confact Info:** add `showAvatar` and `avatarIcon` props ([#981](#981)) ([4a7a674](4a7a674)) * migration to dialtone 8 ([#979](#979)) ([defcb77](defcb77)), closes [#993](#993) * **Modal:** show event and initial-focus-element ([#1009](#1009)) ([935d6da](935d6da)) * **Rich Text Editor:** link extension ([#991](#991)) ([d88e704](d88e704)) * **Rich Text Editor:** tests for rich text editor link extension and utils ([#1001](#1001)) ([b947270](b947270)) * state changes for feed item row ([#1002](#1002)) ([9aeefc6](9aeefc6)) * update dialtone-icons ([1fb19be](1fb19be))

# [2.84.0-beta.1](v2.83.3...v2.84.0-beta.1) (2023-06-14) ### Bug Fixes * add placeholder text for richtexteditor ([#1004](#1004)) ([19e1ef9](19e1ef9)) * bump package version to avoid error ([34738ea](34738ea)) * change to fnv algo ([f6e01a1](f6e01a1)) * component documentation link class ([#985](#985)) ([95c178c](95c178c)) * DIALTONE-1089 pagination muted clear button error ([4bd3170](4bd3170)) * **Keyboard Shortcut:** inverted border color ([b68387c](b68387c)) * **Leftbar General Row:** add href for focusability ([#994](#994)) ([73bc4e0](73bc4e0)) * missing migrations ([7483e16](7483e16)) * **Modal:** secondary action button kind ([#1011](#1011)) ([f899cb8](f899cb8)) * revert [DIALTONE-1089] fix: pagination muted clear button error ([f43066c](f43066c)) * set node engine minimum to 12.20 ([#988](#988)) ([a53db3c](a53db3c)) * update dialtone-icons ([9a8c31a](9a8c31a)) ### Features * **Avatar:** update to flat colors ([#982](#982)) ([469fe05](469fe05)) * **Confact Info:** add `showAvatar` and `avatarIcon` props ([#981](#981)) ([4a7a674](4a7a674)) * migration to dialtone 8 ([#979](#979)) ([defcb77](defcb77)), closes [#993](#993) * **Modal:** show event and initial-focus-element ([#1009](#1009)) ([935d6da](935d6da)) * **Rich Text Editor:** link extension ([#991](#991)) ([d88e704](d88e704)) * **Rich Text Editor:** tests for rich text editor link extension and utils ([#1001](#1001)) ([b947270](b947270)) * state changes for feed item row ([#1002](#1002)) ([9aeefc6](9aeefc6)) * update dialtone-icons ([1fb19be](1fb19be))

# [2.84.0-beta.3](v2.84.0-beta.2...v2.84.0-beta.3) (2023-06-14) ### Bug Fixes * add placeholder text for richtexteditor ([#1004](#1004)) ([19e1ef9](19e1ef9)) * **Contact Row, Group Row, General Row:** null on description ([#1013](#1013)) ([8092faf](8092faf)) * DIALTONE-1089 pagination muted clear button error ([4bd3170](4bd3170)) * **Keyboard Shortcut:** inverted border color ([b68387c](b68387c)) * **Leftbar General Row:** add href for focusability ([#994](#994)) ([73bc4e0](73bc4e0)) * missing migrations ([7483e16](7483e16)) * **Modal:** secondary action button kind ([#1011](#1011)) ([f899cb8](f899cb8)) * revert [DIALTONE-1089] fix: pagination muted clear button error ([f43066c](f43066c)) ### Documentation * fix broken story ([8097ff2](8097ff2)) ### Features * **Datepicker:** datepicker component ([#1007](#1007)) ([335af23](335af23)) * **Modal:** show event and initial-focus-element ([#1009](#1009)) ([935d6da](935d6da)) * **Rich Text Editor:** link extension ([#991](#991)) ([d88e704](d88e704)) * **Rich Text Editor:** tests for rich text editor link extension and utils ([#1001](#1001)) ([b947270](b947270)) * state changes for feed item row ([#1002](#1002)) ([9aeefc6](9aeefc6))

# [2.88.0-beta.1](v2.87.0...v2.88.0-beta.1) (2023-06-22) ### Bug Fixes * add placeholder text for richtexteditor ([#1004](#1004)) ([19e1ef9](19e1ef9)) * change to fnv algo ([f6e01a1](f6e01a1)) * component documentation link class ([#985](#985)) ([95c178c](95c178c)) * **Contact Row, Group Row, General Row:** null on description ([#1013](#1013)) ([8092faf](8092faf)) * DIALTONE-1089 pagination muted clear button error ([4bd3170](4bd3170)) * **Keyboard Shortcut:** inverted border color ([b68387c](b68387c)) * **Leftbar General Row:** add href for focusability ([#994](#994)) ([73bc4e0](73bc4e0)) * missing migrations ([7483e16](7483e16)) * **Modal:** secondary action button kind ([#1011](#1011)) ([f899cb8](f899cb8)) * remove peer dep ([b5be026](b5be026)) * revert [DIALTONE-1089] fix: pagination muted clear button error ([f43066c](f43066c)) * revert feat(modal): show event and initial-focus-element ([#1009](#1009)) ([18cf9ab](18cf9ab)) * set node engine minimum to 12.20 ([#988](#988)) ([a53db3c](a53db3c)) * update dialtone-icons ([9a8c31a](9a8c31a)) ### Documentation * fix broken story ([8097ff2](8097ff2)) ### Features * **Avatar:** update to flat colors ([#982](#982)) ([469fe05](469fe05)) * **Confact Info:** add `showAvatar` and `avatarIcon` props ([#981](#981)) ([4a7a674](4a7a674)) * **Datepicker:** datepicker component ([#1007](#1007)) ([335af23](335af23)) * migration to dialtone 8 ([#979](#979)) ([defcb77](defcb77)), closes [#993](#993) * **Modal:** show event and initial-focus-element ([#1009](#1009)) ([935d6da](935d6da)) * **Rich Text Editor:** link extension ([#991](#991)) ([d88e704](d88e704)) * **Rich Text Editor:** tests for rich text editor link extension and utils ([#1001](#1001)) ([b947270](b947270)) * state changes for feed item row ([#1002](#1002)) ([9aeefc6](9aeefc6)) * update dialtone-icons ([1fb19be](1fb19be))

# [2.84.0-alpha.1](v2.83.3...v2.84.0-alpha.1) (2023-06-23) ### Bug Fixes * add placeholder text for richtexteditor ([#1004](#1004)) ([19e1ef9](19e1ef9)) * change to fnv algo ([f6e01a1](f6e01a1)) * component documentation link class ([#985](#985)) ([95c178c](95c178c)) * **Contact Row, Group Row, General Row:** null on description ([#1013](#1013)) ([8092faf](8092faf)) * DIALTONE-1089 pagination muted clear button error ([4bd3170](4bd3170)) * **Keyboard Shortcut:** inverted border color ([b68387c](b68387c)) * **Leftbar General Row:** add href for focusability ([#994](#994)) ([73bc4e0](73bc4e0)) * missing migrations ([7483e16](7483e16)) * **Modal:** secondary action button kind ([#1011](#1011)) ([f899cb8](f899cb8)) * remove peer dep ([b5be026](b5be026)) * revert [DIALTONE-1089] fix: pagination muted clear button error ([f43066c](f43066c)) * revert feat(modal): show event and initial-focus-element ([#1009](#1009)) ([18cf9ab](18cf9ab)) * **Rich Text Editor:** add a check and workaround for phone regex ([aa5dd34](aa5dd34)) * set node engine minimum to 12.20 ([#988](#988)) ([a53db3c](a53db3c)) * update dialtone-icons ([9a8c31a](9a8c31a)) ### Documentation * fix broken story ([8097ff2](8097ff2)) ### Features * **Avatar:** update to flat colors ([#982](#982)) ([469fe05](469fe05)) * **Confact Info:** add `showAvatar` and `avatarIcon` props ([#981](#981)) ([4a7a674](4a7a674)) * **Datepicker:** datepicker component ([#1007](#1007)) ([335af23](335af23)) * migration to dialtone 8 ([#979](#979)) ([defcb77](defcb77)), closes [#993](#993) * **Modal:** show event and initial-focus-element ([#1009](#1009)) ([935d6da](935d6da)) * **Rich Text Editor:** link extension ([#991](#991)) ([d88e704](d88e704)) * **Rich Text Editor:** tests for rich text editor link extension and utils ([#1001](#1001)) ([b947270](b947270)) * state changes for feed item row ([#1002](#1002)) ([9aeefc6](9aeefc6)) * update dialtone-icons ([1fb19be](1fb19be))

# [2.89.0-beta.1](v2.88.0...v2.89.0-beta.1) (2023-06-23) ### Bug Fixes * add placeholder text for richtexteditor ([#1004](#1004)) ([19e1ef9](19e1ef9)) * change to fnv algo ([f6e01a1](f6e01a1)) * component documentation link class ([#985](#985)) ([95c178c](95c178c)) * **Contact Row, Group Row, General Row:** null on description ([#1013](#1013)) ([8092faf](8092faf)) * DIALTONE-1089 pagination muted clear button error ([4bd3170](4bd3170)) * **Keyboard Shortcut:** inverted border color ([b68387c](b68387c)) * **Leftbar General Row:** add href for focusability ([#994](#994)) ([73bc4e0](73bc4e0)) * missing migrations ([7483e16](7483e16)) * **Modal:** secondary action button kind ([#1011](#1011)) ([f899cb8](f899cb8)) * remove peer dep ([b5be026](b5be026)) * revert [DIALTONE-1089] fix: pagination muted clear button error ([f43066c](f43066c)) * revert feat(modal): show event and initial-focus-element ([#1009](#1009)) ([18cf9ab](18cf9ab)) * set node engine minimum to 12.20 ([#988](#988)) ([a53db3c](a53db3c)) * update dialtone-icons ([9a8c31a](9a8c31a)) ### Documentation * fix broken story ([8097ff2](8097ff2)) ### Features * **Avatar:** update to flat colors ([#982](#982)) ([469fe05](469fe05)) * **Confact Info:** add `showAvatar` and `avatarIcon` props ([#981](#981)) ([4a7a674](4a7a674)) * **Datepicker:** datepicker component ([#1007](#1007)) ([335af23](335af23)) * migration to dialtone 8 ([#979](#979)) ([defcb77](defcb77)), closes [#993](#993) * **Modal:** show event and initial-focus-element ([#1009](#1009)) ([935d6da](935d6da)) * **Rich Text Editor:** link extension ([#991](#991)) ([d88e704](d88e704)) * **Rich Text Editor:** tests for rich text editor link extension and utils ([#1001](#1001)) ([b947270](b947270)) * state changes for feed item row ([#1002](#1002)) ([9aeefc6](9aeefc6)) * update dialtone-icons ([1fb19be](1fb19be))

# [2.90.0-beta.1](v2.89.0...v2.90.0-beta.1) (2023-06-28) ### Bug Fixes * add placeholder text for richtexteditor ([#1004](#1004)) ([19e1ef9](19e1ef9)) * change to fnv algo ([f6e01a1](f6e01a1)) * component documentation link class ([#985](#985)) ([95c178c](95c178c)) * **Contact Row, Group Row, General Row:** null on description ([#1013](#1013)) ([8092faf](8092faf)) * DIALTONE-1089 pagination muted clear button error ([4bd3170](4bd3170)) * **Keyboard Shortcut:** inverted border color ([b68387c](b68387c)) * **Leftbar General Row:** add href for focusability ([#994](#994)) ([73bc4e0](73bc4e0)) * missing migrations ([7483e16](7483e16)) * **Modal:** secondary action button kind ([#1011](#1011)) ([f899cb8](f899cb8)) * package-lock ([de1f160](de1f160)) * remove peer dep ([b5be026](b5be026)) * revert [DIALTONE-1089] fix: pagination muted clear button error ([f43066c](f43066c)) * revert feat(modal): show event and initial-focus-element ([#1009](#1009)) ([18cf9ab](18cf9ab)) * set node engine minimum to 12.20 ([#988](#988)) ([a53db3c](a53db3c)) * update dialtone-icons ([9a8c31a](9a8c31a)) ### Documentation * fix broken story ([8097ff2](8097ff2)) ### Features * **Avatar:** update to flat colors ([#982](#982)) ([469fe05](469fe05)) * **Confact Info:** add `showAvatar` and `avatarIcon` props ([#981](#981)) ([4a7a674](4a7a674)) * **Datepicker:** datepicker component ([#1007](#1007)) ([335af23](335af23)) * Merge branch 'staging' into dialtone8 ([001d2f7](001d2f7)) * migration to dialtone 8 ([#979](#979)) ([defcb77](defcb77)), closes [#993](#993) * **Modal:** show event and initial-focus-element ([#1009](#1009)) ([935d6da](935d6da)) * **Rich Text Editor:** link extension ([#991](#991)) ([d88e704](d88e704)) * **Rich Text Editor:** tests for rich text editor link extension and utils ([#1001](#1001)) ([b947270](b947270)) * state changes for feed item row ([#1002](#1002)) ([9aeefc6](9aeefc6)) * update dialtone-icons ([1fb19be](1fb19be))

# [2.90.0-dialtone8.1](v2.89.0...v2.90.0-dialtone8.1) (2023-06-29) ### Bug Fixes * add placeholder text for richtexteditor ([#1004](#1004)) ([19e1ef9](19e1ef9)) * change to fnv algo ([f6e01a1](f6e01a1)) * component documentation link class ([#985](#985)) ([95c178c](95c178c)) * **Contact Row, Group Row, General Row:** null on description ([#1013](#1013)) ([8092faf](8092faf)) * DIALTONE-1089 pagination muted clear button error ([4bd3170](4bd3170)) * **Keyboard Shortcut:** inverted border color ([b68387c](b68387c)) * **Leftbar General Row:** add href for focusability ([#994](#994)) ([73bc4e0](73bc4e0)) * missing migrations ([7483e16](7483e16)) * **Modal:** secondary action button kind ([#1011](#1011)) ([f899cb8](f899cb8)) * remove peer dep ([b5be026](b5be026)) * revert [DIALTONE-1089] fix: pagination muted clear button error ([f43066c](f43066c)) * set node engine minimum to 12.20 ([#988](#988)) ([a53db3c](a53db3c)) * update dialtone-icons ([9a8c31a](9a8c31a)) ### Code Refactoring * **Datepicker:** name refactoring ([#1049](#1049)) ([f6d34aa](f6d34aa)) * **Datepicker:** name refactoring ([#1049](#1049)) ([75f7146](75f7146)) ### Documentation * fix broken story ([8097ff2](8097ff2)) ### Features * **Avatar:** update to flat colors ([#982](#982)) ([469fe05](469fe05)) * **Confact Info:** add `showAvatar` and `avatarIcon` props ([#981](#981)) ([4a7a674](4a7a674)) * **Datepicker:** datepicker component ([#1007](#1007)) ([335af23](335af23)) * Merge branch 'staging' into dialtone8 ([001d2f7](001d2f7)) * migration to dialtone 8 ([#979](#979)) ([defcb77](defcb77)), closes [#993](#993) * **Modal:** show event and initial-focus-element ([#1009](#1009)) ([935d6da](935d6da)) * **Rich Text Editor:** link extension ([#991](#991)) ([d88e704](d88e704)) * **Rich Text Editor:** tests for rich text editor link extension and utils ([#1001](#1001)) ([b947270](b947270)) * state changes for feed item row ([#1002](#1002)) ([9aeefc6](9aeefc6)) * update dialtone-icons ([1fb19be](1fb19be))

# [2.93.0-dialtone8.1](v2.92.4...v2.93.0-dialtone8.1) (2023-07-27) ### Bug Fixes * `contact_info` style override issue ([#1078](#1078)) ([2090704](2090704)) * add customized css to badge label and contact info ([#1076](#1076)) ([6e8b374](6e8b374)) * add placeholder text for richtexteditor ([#1004](#1004)) ([19e1ef9](19e1ef9)) * **Avatar:** thin border behind image ([#1098](#1098)) ([c942386](c942386)) * change to fnv algo ([f6e01a1](f6e01a1)) * **Combobox Multi Select:** fix ref not existing error ([#1083](#1083)) ([de054f4](de054f4)) * component documentation link class ([#985](#985)) ([95c178c](95c178c)) * **Contact Info Avatar:** show avatar halo as required ([#1059](#1059)) ([b429531](b429531)) * **Contact Info, Leftbar Row:** stylings ([#1085](#1085)) ([34c27e8](34c27e8)) * **Contact Info:** avatar's border color ([#1097](#1097)) ([1639989](1639989)) * **Contact Row, Group Row, General Row:** null on description ([#1013](#1013)) ([8092faf](8092faf)) * DIALTONE-1089 pagination muted clear button error ([4bd3170](4bd3170)) * **General Row:** adjust label width on prop change ([#1095](#1095)) ([01ed220](01ed220)) * **General Row:** call resize handler on mounted ([#1093](#1093)) ([53768c1](53768c1)) * **General Row:** overridden display property ([#1069](#1069)) ([7b5f27b](7b5f27b)) * **General Row:** resize observer ([#1074](#1074)) ([7e27e9c](7e27e9c)) * **Item Layout:** remove align-self from item layout ([80ab209](80ab209)) * **Keyboard Shortcut:** inverted border color ([b68387c](b68387c)) * **Leftbar General Row:** add href for focusability ([#994](#994)) ([73bc4e0](73bc4e0)) * merge branch 'staging' into dialtone8 ([aa95eb4](aa95eb4)) * merge branch 'staging' into dialtone8 ([2dec412](2dec412)) * missing migrations ([7483e16](7483e16)) * **Modal:** secondary action button kind ([#1011](#1011)) ([f899cb8](f899cb8)) * package-lock ([48f3120](48f3120)) * remove peer dep ([b5be026](b5be026)) * revert [DIALTONE-1089] fix: pagination muted clear button error ([f43066c](f43066c)) * set node engine minimum to 12.20 ([#988](#988)) ([a53db3c](a53db3c)) * **Tooltip:** change anchor tag to span ([#1088](#1088)) ([0735fc8](0735fc8)) * update dialtone-icons ([9a8c31a](9a8c31a)) ### Code Refactoring * **Datepicker:** name refactoring ([#1049](#1049)) ([f6d34aa](f6d34aa)) ### Documentation * **Collapsible:** fix opened event not displayed on panel ([#1064](#1064)) ([51a8f52](51a8f52)) * fix broken story ([8097ff2](8097ff2)) ### Features * **Avatar:** update to flat colors ([#982](#982)) ([469fe05](469fe05)) * **Confact Info:** add `showAvatar` and `avatarIcon` props ([#981](#981)) ([4a7a674](4a7a674)) * **Datepicker:** date format utils ([#1060](#1060)) ([42b8572](42b8572)) * **Datepicker:** datepicker component ([#1007](#1007)) ([335af23](335af23)) * **General Row:** overridden display property ([#1069](#1069)) ([d6fd5ac](d6fd5ac)) * **General Row:** overridden display property ([#1069](#1069)) ([080afc0](080afc0)) * merge branch 'staging' into dialtone8 ([cf8d810](cf8d810)) * Merge branch 'staging' into dialtone8 ([001d2f7](001d2f7)) * migration to dialtone 8 ([#979](#979)) ([defcb77](defcb77)), closes [#993](#993) * **Modal:** show event and initial-focus-element ([#1009](#1009)) ([935d6da](935d6da)) * **Rich Text Editor:** link extension ([#991](#991)) ([d88e704](d88e704)) * **Rich Text Editor:** tests for rich text editor link extension and utils ([#1001](#1001)) ([b947270](b947270)) * state changes for feed item row ([#1002](#1002)) ([9aeefc6](9aeefc6)) * update dialtone-icons ([1fb19be](1fb19be)) * update item-layout to use tokens ([c9151aa](c9151aa)) ### Reverts * Revert "feat(general-row): overridden display property (#1069)" ([3e619ba](3e619ba)), closes [#1069](#1069) * revert fix(general-row): overridden display property (#1069) ([5355902](5355902)), closes [#1069](#1069)

# [2.93.0](v2.92.4...v2.93.0) (2023-08-04) ### Bug Fixes * `contact_info` style override issue ([#1078](#1078)) ([2090704](2090704)) * add customized css to badge label and contact info ([#1076](#1076)) ([6e8b374](6e8b374)) * add placeholder text for richtexteditor ([#1004](#1004)) ([19e1ef9](19e1ef9)) * **Avatar:** remove util classes, set tokens ([#1106](#1106)) ([3a24d2c](3a24d2c)) * **Avatar:** thin border behind image ([#1098](#1098)) ([c942386](c942386)) * change to fnv algo ([f6e01a1](f6e01a1)) * **Combobox Multi Select:** fix ref not existing error ([#1083](#1083)) ([de054f4](de054f4)) * component documentation link class ([#985](#985)) ([95c178c](95c178c)) * **Contact Info Avatar:** show avatar halo as required ([#1059](#1059)) ([b429531](b429531)) * **Contact Info, Leftbar Row:** stylings ([#1085](#1085)) ([34c27e8](34c27e8)) * **Contact Info:** avatar's border color ([#1097](#1097)) ([1639989](1639989)) * **Contact Row, Group Row, General Row:** null on description ([#1013](#1013)) ([8092faf](8092faf)) * DIALTONE-1089 pagination muted clear button error ([4bd3170](4bd3170)) * **General Row:** adjust label width on prop change ([#1095](#1095)) ([01ed220](01ed220)) * **General Row:** call resize handler on mounted ([#1093](#1093)) ([53768c1](53768c1)) * **General Row:** overridden display property ([#1069](#1069)) ([7b5f27b](7b5f27b)) * **General Row:** resize observer ([#1074](#1074)) ([7e27e9c](7e27e9c)) * **Item Layout:** remove align-self from item layout ([80ab209](80ab209)) * **Keyboard Shortcut:** inverted border color ([b68387c](b68387c)) * **Leftbar General Row:** add href for focusability ([#994](#994)) ([73bc4e0](73bc4e0)) * **Leftbar Row:** presence border color on selected row ([#1110](#1110)) ([05c9b15](05c9b15)) * merge branch 'staging' into dialtone8 ([aa95eb4](aa95eb4)) * merge branch 'staging' into dialtone8 ([2dec412](2dec412)) * missing migrations ([7483e16](7483e16)) * **Modal:** secondary action button kind ([#1011](#1011)) ([f899cb8](f899cb8)) * package-lock ([48f3120](48f3120)) * remove peer dep ([b5be026](b5be026)) * revert [DIALTONE-1089] fix: pagination muted clear button error ([f43066c](f43066c)) * set node engine minimum to 12.20 ([#988](#988)) ([a53db3c](a53db3c)) * **Tooltip:** change anchor tag to span ([#1088](#1088)) ([0735fc8](0735fc8)) * update dialtone-icons ([9a8c31a](9a8c31a)) ### Code Refactoring * **Datepicker:** name refactoring ([#1049](#1049)) ([f6d34aa](f6d34aa)) ### Documentation * **Collapsible:** fix opened event not displayed on panel ([#1064](#1064)) ([51a8f52](51a8f52)) * fix broken story ([8097ff2](8097ff2)) ### Features * add typescript ([#1108](#1108)) ([4f5e2ec](4f5e2ec)) * **Avatar:** add icon-class prop ([#1111](#1111)) ([43b0561](43b0561)) * **Avatar:** extract initials from full name ([6c80963](6c80963)) * **Avatar:** extract initials from full name ([#1102](#1102)) ([3082209](3082209)), closes [#1097](#1097) [#1098](#1098) * **Avatar:** update to flat colors ([#982](#982)) ([469fe05](469fe05)) * **Confact Info:** add `showAvatar` and `avatarIcon` props ([#981](#981)) ([4a7a674](4a7a674)) * **Datepicker:** date format utils ([#1060](#1060)) ([42b8572](42b8572)) * **Datepicker:** datepicker component ([#1007](#1007)) ([335af23](335af23)) * **General Row:** overridden display property ([#1069](#1069)) ([d6fd5ac](d6fd5ac)) * **General Row:** overridden display property ([#1069](#1069)) ([080afc0](080afc0)) * merge branch 'staging' into dialtone8 ([cf8d810](cf8d810)) * Merge branch 'staging' into dialtone8 ([001d2f7](001d2f7)) * migration to dialtone 8 ([#979](#979)) ([defcb77](defcb77)), closes [#993](#993) * **Modal:** show event and initial-focus-element ([#1009](#1009)) ([935d6da](935d6da)) * **Rich Text Editor:** link extension ([#991](#991)) ([d88e704](d88e704)) * **Rich Text Editor:** tests for rich text editor link extension and utils ([#1001](#1001)) ([b947270](b947270)) * state changes for feed item row ([#1002](#1002)) ([9aeefc6](9aeefc6)) * update dialtone-icons ([1fb19be](1fb19be)) * update item-layout to use tokens ([c9151aa](c9151aa)) ### Reverts * Revert "feat(general-row): overridden display property (#1069)" ([3e619ba](3e619ba)), closes [#1069](#1069) * revert fix(general-row): overridden display property (#1069) ([5355902](5355902)), closes [#1069](#1069)

feat: state changes for feed item row

f9f22c5

sanjeevdialpad requested review from juliodialpad, iropolo and braddialpad as code owners May 30, 2023 17:35

braddialpad suggested changes May 30, 2023

View reviewed changes

default state value

b15507d

iropolo approved these changes Jun 5, 2023

View reviewed changes

fade using ref

49eae04

sanjeevdialpad requested a review from braddialpad June 5, 2023 18:41

braddialpad approved these changes Jun 5, 2023

View reviewed changes

Merge branch 'staging' into DT-573

bc09d89

sanjeevdialpad merged commit 5838862 into staging Jun 5, 2023

sanjeevdialpad deleted the DT-573 branch June 5, 2023 20:27

juliodialpad pushed a commit that referenced this pull request Jun 9, 2023

feat: state changes for feed item row (#1002)

9aeefc6

github-actions bot added the released label Jun 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: state changes for feed item row #1002

feat: state changes for feed item row #1002

sanjeevdialpad commented May 30, 2023

github-actions bot commented May 30, 2023

github-actions bot commented May 30, 2023

braddialpad May 30, 2023

sanjeevdialpad Jun 5, 2023

braddialpad May 30, 2023

iropolo May 31, 2023 •

edited

Loading

sanjeevdialpad Jun 1, 2023

github-actions bot commented Jun 2, 2023

iropolo left a comment •

edited

Loading

github-actions bot commented Jun 5, 2023

braddialpad left a comment

github-actions bot commented Jun 5, 2023

github-actions bot commented Jun 13, 2023

feat: state changes for feed item row #1002

feat: state changes for feed item row #1002

Conversation

sanjeevdialpad commented May 30, 2023

State changes for Feed item Row

🛠️ Type Of Change

📖 Description

💡 Context

📝 Checklist

🔮 Next Steps

📷 Screenshots / GIFs

🔗 Sources

github-actions bot commented May 30, 2023

github-actions bot commented May 30, 2023

braddialpad May 30, 2023

Choose a reason for hiding this comment

sanjeevdialpad Jun 5, 2023

Choose a reason for hiding this comment

braddialpad May 30, 2023

Choose a reason for hiding this comment

iropolo May 31, 2023 • edited Loading

Choose a reason for hiding this comment

sanjeevdialpad Jun 1, 2023

Choose a reason for hiding this comment

github-actions bot commented Jun 2, 2023

iropolo left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jun 5, 2023

braddialpad left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 5, 2023

github-actions bot commented Jun 13, 2023

iropolo May 31, 2023 •

edited

Loading

iropolo left a comment •

edited

Loading