Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

fix(avatar): remove util classes, set tokens #1106

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

braddialpad
Copy link
Contributor

@braddialpad braddialpad commented Jul 27, 2023

fix(avatar): remove util classes, set tokens

πŸ› οΈ Type Of Change

  • Fix
  • Feature
  • Refactoring
  • Documentation

πŸ“– Description

Remove avatar utility classes because we were having specificity issues with contact info component passing in classes via avatar-class.

All these classes SHOULD be moved to dialtone and properly documented, but don't have time to do that at the moment so just making the fixes in dt-vue

@github-actions
Copy link

βœ”οΈ Deploy Preview ready!
😎 Browse the preview: https://vue.dialpad.design/deploy-previews/pr-1106/
πŸ”¨ If you experience an SSL issue then wait 2 minutes and try again.

@github-actions github-actions bot added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label Jul 27, 2023
@braddialpad braddialpad merged commit 3a24d2c into dialtone8 Jul 27, 2023
3 checks passed
@braddialpad braddialpad deleted the avatar/remove-util-classes branch July 27, 2023 22:15
braddialpad pushed a commit that referenced this pull request Jul 31, 2023
# [2.93.0-dialtone8.2](v2.93.0-dialtone8.1...v2.93.0-dialtone8.2) (2023-07-31)

### Bug Fixes

* **Avatar:** remove util classes, set tokens ([#1106](#1106)) ([3a24d2c](3a24d2c))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 2.93.0-next.2 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

juliodialpad pushed a commit that referenced this pull request Aug 4, 2023
# [2.93.0](v2.92.4...v2.93.0) (2023-08-04)

### Bug Fixes

* `contact_info` style override issue ([#1078](#1078)) ([2090704](2090704))
* add customized css to badge label and contact info ([#1076](#1076)) ([6e8b374](6e8b374))
* add placeholder text for richtexteditor ([#1004](#1004)) ([19e1ef9](19e1ef9))
* **Avatar:** remove util classes, set tokens ([#1106](#1106)) ([3a24d2c](3a24d2c))
* **Avatar:** thin border behind image ([#1098](#1098)) ([c942386](c942386))
* change to fnv algo ([f6e01a1](f6e01a1))
* **Combobox Multi Select:** fix ref not existing error ([#1083](#1083)) ([de054f4](de054f4))
* component documentation link class ([#985](#985)) ([95c178c](95c178c))
* **Contact Info Avatar:** show avatar halo as required ([#1059](#1059)) ([b429531](b429531))
* **Contact Info, Leftbar Row:** stylings ([#1085](#1085)) ([34c27e8](34c27e8))
* **Contact Info:** avatar's border color ([#1097](#1097)) ([1639989](1639989))
* **Contact Row, Group Row, General Row:** null on description ([#1013](#1013)) ([8092faf](8092faf))
* DIALTONE-1089 pagination muted clear button error ([4bd3170](4bd3170))
* **General Row:** adjust label width on prop change ([#1095](#1095)) ([01ed220](01ed220))
* **General Row:** call resize handler on mounted ([#1093](#1093)) ([53768c1](53768c1))
* **General Row:** overridden display property ([#1069](#1069)) ([7b5f27b](7b5f27b))
* **General Row:** resize observer ([#1074](#1074)) ([7e27e9c](7e27e9c))
* **Item Layout:** remove align-self from item layout ([80ab209](80ab209))
* **Keyboard Shortcut:** inverted border color ([b68387c](b68387c))
* **Leftbar General Row:** add href for focusability ([#994](#994)) ([73bc4e0](73bc4e0))
* **Leftbar Row:** presence border color on selected row ([#1110](#1110)) ([05c9b15](05c9b15))
* merge branch 'staging' into dialtone8 ([aa95eb4](aa95eb4))
* merge branch 'staging' into dialtone8 ([2dec412](2dec412))
* missing migrations ([7483e16](7483e16))
* **Modal:** secondary action button kind ([#1011](#1011)) ([f899cb8](f899cb8))
* package-lock ([48f3120](48f3120))
* remove peer dep ([b5be026](b5be026))
* revert [DIALTONE-1089] fix: pagination muted clear button error ([f43066c](f43066c))
* set node engine minimum to 12.20 ([#988](#988)) ([a53db3c](a53db3c))
* **Tooltip:** change anchor tag to span ([#1088](#1088)) ([0735fc8](0735fc8))
* update dialtone-icons ([9a8c31a](9a8c31a))

### Code Refactoring

* **Datepicker:** name refactoring ([#1049](#1049)) ([f6d34aa](f6d34aa))

### Documentation

* **Collapsible:** fix opened event not displayed on panel ([#1064](#1064)) ([51a8f52](51a8f52))
* fix broken story ([8097ff2](8097ff2))

### Features

* add typescript ([#1108](#1108)) ([4f5e2ec](4f5e2ec))
* **Avatar:** add icon-class prop ([#1111](#1111)) ([43b0561](43b0561))
* **Avatar:** extract initials from full name ([6c80963](6c80963))
* **Avatar:** extract initials from full name ([#1102](#1102)) ([3082209](3082209)), closes [#1097](#1097) [#1098](#1098)
* **Avatar:** update to flat colors ([#982](#982)) ([469fe05](469fe05))
* **Confact Info:** add `showAvatar` and `avatarIcon` props ([#981](#981)) ([4a7a674](4a7a674))
* **Datepicker:** date format utils ([#1060](#1060)) ([42b8572](42b8572))
* **Datepicker:** datepicker component ([#1007](#1007)) ([335af23](335af23))
* **General Row:** overridden display property ([#1069](#1069)) ([d6fd5ac](d6fd5ac))
* **General Row:** overridden display property ([#1069](#1069)) ([080afc0](080afc0))
* merge branch 'staging' into dialtone8 ([cf8d810](cf8d810))
* Merge branch 'staging' into dialtone8 ([001d2f7](001d2f7))
* migration to dialtone 8 ([#979](#979)) ([defcb77](defcb77)), closes [#993](#993)
* **Modal:** show event and initial-focus-element ([#1009](#1009)) ([935d6da](935d6da))
* **Rich Text Editor:** link extension ([#991](#991)) ([d88e704](d88e704))
* **Rich Text Editor:** tests for rich text editor link extension and utils ([#1001](#1001)) ([b947270](b947270))
* state changes for feed item row ([#1002](#1002)) ([9aeefc6](9aeefc6))
* update dialtone-icons ([1fb19be](1fb19be))
* update item-layout to use tokens ([c9151aa](c9151aa))

### Reverts

* Revert "feat(general-row): overridden display property (#1069)" ([3e619ba](3e619ba)), closes [#1069](#1069)
* revert fix(general-row): overridden display property (#1069) ([5355902](5355902)), closes [#1069](#1069)
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

πŸŽ‰ This PR is included in version 2.93.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released on @next released visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants