This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
fix(leftbar-row): avatar presence color on selected row #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braddialpad
approved these changes
Aug 2, 2023
|
✔️ Deploy Preview ready! |
github-actions
bot
added
the
visual-test-ready
|
Need vue3 for this? |
juliodialpad
pushed a commit
that referenced
this pull request
Aug 2, 2023
# [2.93.0-dialtone8.4](v2.93.0-dialtone8.3...v2.93.0-dialtone8.4) (2023-08-02) ### Bug Fixes * **Leftbar Row:** presence border color on selected row ([#1110](#1110)) ([05c9b15](05c9b15))
juliodialpad
added a commit
that referenced
this pull request
Aug 2, 2023
|
🎉 This PR is included in version 2.93.0-next.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
juliodialpad
pushed a commit
that referenced
this pull request
Aug 2, 2023
# [3.80.0-dialtone8-vue3.2](v3.80.0-dialtone8-vue3.1...v3.80.0-dialtone8-vue3.2) (2023-08-02) ### Bug Fixes * **Avatar:** extract initials from full name - vue 3 ([b8bb929](b8bb929)) * **Avatar:** remove util classes, set tokens ([#1107](#1107)) ([7c02be8](7c02be8)) * **Leftbar Row:** presence border color on selected row ([#1110](#1110)) ([021b37c](021b37c)) * **Tooltip:** anchor display property issue ([#1104](#1104)) ([f9447ec](f9447ec))
juliodialpad
pushed a commit
that referenced
this pull request
Aug 2, 2023
# [3.80.0-dialtone8-vue3.2](v3.80.0-dialtone8-vue3.1...v3.80.0-dialtone8-vue3.2) (2023-08-02) ### Bug Fixes * **Avatar:** extract initials from full name - vue 3 ([b8bb929](b8bb929)) * **Avatar:** remove util classes, set tokens ([#1107](#1107)) ([7c02be8](7c02be8)) * **Leftbar Row:** presence border color on selected row ([#1110](#1110)) ([021b37c](021b37c)) * **Tooltip:** anchor display property issue ([#1104](#1104)) ([f9447ec](f9447ec))
juliodialpad
pushed a commit
that referenced
this pull request
Aug 2, 2023
# [3.80.0-dialtone8-vue3.1](v3.79.0...v3.80.0-dialtone8-vue3.1) (2023-08-02) ### Bug Fixes * `contact_info` style override issue (Vue3) ([#1079](#1079)) ([1826f1c](1826f1c)) * add customized css to badge label and contact info (vue3) ([#1077](#1077)) ([b1c3821](b1c3821)) * **Avatar:** extract initials from full name - vue 3 ([b8bb929](b8bb929)) * **Avatar:** remove util classes, set tokens ([#1107](#1107)) ([7c02be8](7c02be8)) * **Avatar:** thin border behind image ([#1099](#1099)) ([e66fc86](e66fc86)) * change prerelease name ([f8f9771](f8f9771)) * **Combobox Multi Select:** fix ref not existing error ([#1084](#1084)) ([c72d796](c72d796)) * **Contact Info Avatar:** show avatar halo as required vue3 ([#1062](#1062)) ([53a882c](53a882c)) * **Contact Info, Leftbar Row:** stylings - vue3 ([#1086](#1086)) ([594fdca](594fdca)), closes [#1062](#1062) [#1061](#1061) * **Contact Info:** avatar's border color ([#1100](#1100)) ([917de63](917de63)) * fix emoji skin tone not updating when skinTone prop updates ([#1087](#1087)) ([d27d870](d27d870)) * **General Row:** adjust label width on prop change ([#1096](#1096)) ([d4868cf](d4868cf)) * **General Row:** call resize handler on mounted ([#1094](#1094)) ([51de1c0](51de1c0)) * **General Row:** overridden display property - vue3 ([#1070](#1070)) ([fd1703b](fd1703b)) * **General Row:** resize observer - vue3 ([#1075](#1075)) ([a39b917](a39b917)) * **Item Layout:** remove align-self from item layout ([408032f](408032f)) * **Leftbar Row:** presence border color on selected row ([#1110](#1110)) ([021b37c](021b37c)) * local config? ([6f6c27b](6f6c27b)) * merge branch 'staging-vue3' into dialtone8-vue3 ([64d097f](64d097f)) * **Message Input:** message input recipe tests ([#1073](#1073)) ([bab14a5](bab14a5)) * remove peer dep for dt8 branch ([267a773](267a773)) * **Tooltip:** anchor display property issue ([#1104](#1104)) ([f9447ec](f9447ec)) * **Tooltip:** change anchor tag to span ([#1089](#1089)) ([3c8e855](3c8e855)) ### Documentation * **Collapsible:** fix opened event not displayed on panel ([#1065](#1065)) ([a7c19c5](a7c19c5)) * **Multiple Components:** missing migrations - vue3 ([#1090](#1090)) ([614ab18](614ab18)) ### Features * **Datepicker:** date format utils vue3 ([#1061](#1061)) ([c0b4570](c0b4570)) * merge branch 'staging-vue3' into dialtone8-vue3 ([317ade0](317ade0)) * migration to dialtone 8 ([eed043d](eed043d)) * **Rich Text Editor:** add hardbreak and codeblocks ([#1068](#1068)) ([bbf24db](bbf24db)) * update item-layout to use tokens ([14cfa99](14cfa99))
Forgot to create the PR, but CP'd the commit on dialtone8-vue3 branch |
juliodialpad
pushed a commit
that referenced
this pull request
Aug 4, 2023
# [2.93.0](v2.92.4...v2.93.0) (2023-08-04) ### Bug Fixes * `contact_info` style override issue ([#1078](#1078)) ([2090704](2090704)) * add customized css to badge label and contact info ([#1076](#1076)) ([6e8b374](6e8b374)) * add placeholder text for richtexteditor ([#1004](#1004)) ([19e1ef9](19e1ef9)) * **Avatar:** remove util classes, set tokens ([#1106](#1106)) ([3a24d2c](3a24d2c)) * **Avatar:** thin border behind image ([#1098](#1098)) ([c942386](c942386)) * change to fnv algo ([f6e01a1](f6e01a1)) * **Combobox Multi Select:** fix ref not existing error ([#1083](#1083)) ([de054f4](de054f4)) * component documentation link class ([#985](#985)) ([95c178c](95c178c)) * **Contact Info Avatar:** show avatar halo as required ([#1059](#1059)) ([b429531](b429531)) * **Contact Info, Leftbar Row:** stylings ([#1085](#1085)) ([34c27e8](34c27e8)) * **Contact Info:** avatar's border color ([#1097](#1097)) ([1639989](1639989)) * **Contact Row, Group Row, General Row:** null on description ([#1013](#1013)) ([8092faf](8092faf)) * DIALTONE-1089 pagination muted clear button error ([4bd3170](4bd3170)) * **General Row:** adjust label width on prop change ([#1095](#1095)) ([01ed220](01ed220)) * **General Row:** call resize handler on mounted ([#1093](#1093)) ([53768c1](53768c1)) * **General Row:** overridden display property ([#1069](#1069)) ([7b5f27b](7b5f27b)) * **General Row:** resize observer ([#1074](#1074)) ([7e27e9c](7e27e9c)) * **Item Layout:** remove align-self from item layout ([80ab209](80ab209)) * **Keyboard Shortcut:** inverted border color ([b68387c](b68387c)) * **Leftbar General Row:** add href for focusability ([#994](#994)) ([73bc4e0](73bc4e0)) * **Leftbar Row:** presence border color on selected row ([#1110](#1110)) ([05c9b15](05c9b15)) * merge branch 'staging' into dialtone8 ([aa95eb4](aa95eb4)) * merge branch 'staging' into dialtone8 ([2dec412](2dec412)) * missing migrations ([7483e16](7483e16)) * **Modal:** secondary action button kind ([#1011](#1011)) ([f899cb8](f899cb8)) * package-lock ([48f3120](48f3120)) * remove peer dep ([b5be026](b5be026)) * revert [DIALTONE-1089] fix: pagination muted clear button error ([f43066c](f43066c)) * set node engine minimum to 12.20 ([#988](#988)) ([a53db3c](a53db3c)) * **Tooltip:** change anchor tag to span ([#1088](#1088)) ([0735fc8](0735fc8)) * update dialtone-icons ([9a8c31a](9a8c31a)) ### Code Refactoring * **Datepicker:** name refactoring ([#1049](#1049)) ([f6d34aa](f6d34aa)) ### Documentation * **Collapsible:** fix opened event not displayed on panel ([#1064](#1064)) ([51a8f52](51a8f52)) * fix broken story ([8097ff2](8097ff2)) ### Features * add typescript ([#1108](#1108)) ([4f5e2ec](4f5e2ec)) * **Avatar:** add icon-class prop ([#1111](#1111)) ([43b0561](43b0561)) * **Avatar:** extract initials from full name ([6c80963](6c80963)) * **Avatar:** extract initials from full name ([#1102](#1102)) ([3082209](3082209)), closes [#1097](#1097) [#1098](#1098) * **Avatar:** update to flat colors ([#982](#982)) ([469fe05](469fe05)) * **Confact Info:** add `showAvatar` and `avatarIcon` props ([#981](#981)) ([4a7a674](4a7a674)) * **Datepicker:** date format utils ([#1060](#1060)) ([42b8572](42b8572)) * **Datepicker:** datepicker component ([#1007](#1007)) ([335af23](335af23)) * **General Row:** overridden display property ([#1069](#1069)) ([d6fd5ac](d6fd5ac)) * **General Row:** overridden display property ([#1069](#1069)) ([080afc0](080afc0)) * merge branch 'staging' into dialtone8 ([cf8d810](cf8d810)) * Merge branch 'staging' into dialtone8 ([001d2f7](001d2f7)) * migration to dialtone 8 ([#979](#979)) ([defcb77](defcb77)), closes [#993](#993) * **Modal:** show event and initial-focus-element ([#1009](#1009)) ([935d6da](935d6da)) * **Rich Text Editor:** link extension ([#991](#991)) ([d88e704](d88e704)) * **Rich Text Editor:** tests for rich text editor link extension and utils ([#1001](#1001)) ([b947270](b947270)) * state changes for feed item row ([#1002](#1002)) ([9aeefc6](9aeefc6)) * update dialtone-icons ([1fb19be](1fb19be)) * update item-layout to use tokens ([c9151aa](c9151aa)) ### Reverts * Revert "feat(general-row): overridden display property (#1069)" ([3e619ba](3e619ba)), closes [#1069](#1069) * revert fix(general-row): overridden display property (#1069) ([5355902](5355902)), closes [#1069](#1069)
juliodialpad
pushed a commit
that referenced
this pull request
Aug 4, 2023
# [3.80.0](v3.79.0...v3.80.0) (2023-08-04) ### Bug Fixes * `contact_info` style override issue (Vue3) ([#1079](#1079)) ([1826f1c](1826f1c)) * add customized css to badge label and contact info (vue3) ([#1077](#1077)) ([b1c3821](b1c3821)) * **Avatar:** extract initials from full name - vue 3 ([b8bb929](b8bb929)) * **Avatar:** remove util classes, set tokens ([#1107](#1107)) ([7c02be8](7c02be8)) * **Avatar:** thin border behind image ([#1099](#1099)) ([e66fc86](e66fc86)) * change prerelease name ([f8f9771](f8f9771)) * **Combobox Multi Select:** fix ref not existing error ([#1084](#1084)) ([c72d796](c72d796)) * **Contact Info Avatar:** show avatar halo as required vue3 ([#1062](#1062)) ([53a882c](53a882c)) * **Contact Info, Leftbar Row:** stylings - vue3 ([#1086](#1086)) ([594fdca](594fdca)), closes [#1062](#1062) [#1061](#1061) * **Contact Info:** avatar's border color ([#1100](#1100)) ([917de63](917de63)) * fix emoji skin tone not updating when skinTone prop updates ([#1087](#1087)) ([d27d870](d27d870)) * **General Row:** adjust label width on prop change ([#1096](#1096)) ([d4868cf](d4868cf)) * **General Row:** call resize handler on mounted ([#1094](#1094)) ([51de1c0](51de1c0)) * **General Row:** overridden display property - vue3 ([#1070](#1070)) ([fd1703b](fd1703b)) * **General Row:** resize observer - vue3 ([#1075](#1075)) ([a39b917](a39b917)) * **Item Layout:** remove align-self from item layout ([408032f](408032f)) * **Leftbar Row:** presence border color on selected row ([#1110](#1110)) ([021b37c](021b37c)) * local config? ([6f6c27b](6f6c27b)) * merge branch 'staging-vue3' into dialtone8-vue3 ([64d097f](64d097f)) * **Message Input:** message input recipe tests ([#1073](#1073)) ([bab14a5](bab14a5)) * remove peer dep for dt8 branch ([267a773](267a773)) * **Tooltip:** anchor display property issue ([#1104](#1104)) ([f9447ec](f9447ec)) * **Tooltip:** anchor display property issue ([#1104](#1104)) ([f12523e](f12523e)) * **Tooltip:** change anchor tag to span ([#1089](#1089)) ([3c8e855](3c8e855)) ### Documentation * **Collapsible:** fix opened event not displayed on panel ([#1065](#1065)) ([a7c19c5](a7c19c5)) * **Multiple Components:** missing migrations - vue3 ([#1090](#1090)) ([614ab18](614ab18)) ### Features * add typescript - vue3 ([#1109](#1109)) ([0208f9c](0208f9c)) * **Avatar:** add icon-class prop ([#1112](#1112)) ([94aca09](94aca09)) * **Avatar:** extract initials from full name - vue3 ([#1103](#1103)) ([4573aec](4573aec)), closes [#1097](#1097) [#1098](#1098) * **Datepicker:** date format utils vue3 ([#1061](#1061)) ([c0b4570](c0b4570)) * merge branch 'staging-vue3' into dialtone8-vue3 ([317ade0](317ade0)) * migration to dialtone 8 ([eed043d](eed043d)) * **Rich Text Editor:** add hardbreak and codeblocks ([#1068](#1068)) ([bbf24db](bbf24db)) * update item-layout to use tokens ([14cfa99](14cfa99))
|
🎉 This PR is included in version 2.93.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix(Leftbar row): Avatar presence color on selected row
🛠️ Type Of Change
📖 Description
Changed presence color on selected state
💡 Context
Noticed the avatar's presence border on lefbar selected row was not correct.
📝 Checklist
📷 Screenshots / GIFs