Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

feat: add avatar click event in contact info (vue3) #1165

Merged
merged 7 commits into from
Sep 14, 2023
Merged

feat: add avatar click event in contact info (vue3) #1165

merged 7 commits into from
Sep 14, 2023

Conversation

tonydialpad
Copy link
Contributor

🛠️ Type Of Change

  • Fix
  • Feature
  • Refactoring
  • Documentation

📖 Description

This pull request adds avatar-click event in contact info component.

💡 Context

When a user clicks on any of the avatars in the callbar when on a call with multiple other participants (i.e. a group call) it opens the “Manage participants” modal. To implement that, we need to add avatar-click event in contact info component.

📝 Checklist

  • I have reviewed my changes
  • I have added tests
  • I have added all relevant documentation
  • I have validated components with a screen reader
  • I have validated components keyboard navigation
  • I have considered the performance impact of my change
  • I have checked that my change did not significantly increase bundle size
  • I am exporting any new components or constants in the index.js in the component directory
  • I am exporting any new components or constants in the index.js in the root

🔮 Next Steps

Make a new release for dialtone-vue

📷 Screenshots / GIFs

No UI update

🔗 Sources

JIRA: https://dialpad.atlassian.net/browse/DP-71224
Vue2 PR: #1164

@tonydialpad tonydialpad mentioned this pull request Sep 9, 2023
Merged
13 tasks
@tonydialpad tonydialpad changed the base branch from staging to staging-vue3 September 9, 2023 00:19
iropolo
iropolo suggested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@iropolo iropolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update branch with changes in Vue2 version #1164

@iropolo iropolo mentioned this pull request Sep 13, 2023
Merged
13 tasks
@github-actions
Copy link

✔️ Deploy Preview ready!
😎 Browse the preview: https://vue.dialpad.design/deploy-previews/pr-1165/
🔨 If you experience an SSL issue then wait 2 minutes and try again.

iropolo
iropolo approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@iropolo iropolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label Sep 14, 2023
@github-actions
Copy link

✔️ Deploy Preview ready!
😎 Browse the preview: https://vue.dialpad.design/deploy-previews/pr-1165/
🔨 If you experience an SSL issue then wait 2 minutes and try again.

@tonydialpad tonydialpad merged commit 7d4f645 into staging-vue3 Sep 14, 2023
10 checks passed
@tonydialpad tonydialpad deleted the add-avatar-click-event-in-contact-info-vue3 branch September 14, 2023 17:05
braddialpad pushed a commit that referenced this pull request Sep 14, 2023
@semantic-release-bot
chore(release): 3.85.0
c4c1ed6 
# [3.85.0](v3.84.0...v3.85.0) (2023-09-14)

### Bug Fixes

* feed pill not exported ([#1181](#1181)) ([c18fc09](c18fc09))

### Features

* add avatar click event in contact info (vue3) ([#1165](#1165)) ([7d4f645](7d4f645))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iropolo iropolo iropolo approved these changes

@braddialpad braddialpad braddialpad approved these changes

@juliodialpad juliodialpad Awaiting requested review from juliodialpad juliodialpad is a code owner

Assignees
No one assigned
Labels
visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonydialpad @braddialpad @iropolo