Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

fix(feed-item,feed-item-row): fix avatar alignment #1171

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix(feed-item,feed-item-row): fix avatar alignment #1171

merged 1 commit into from
Sep 13, 2023

Conversation

eabrakov
Copy link
Contributor

DLT-1223 fix feed item avatar alignment

🛠️ Type Of Change

  • Fix
  • Feature
  • Refactoring
  • Documentation

📝 Checklist

  • I have reviewed my changes
  • I have added tests
  • I have added all relevant documentation
  • I have validated components with a screen reader
  • I have validated components keyboard navigation
  • I have considered the performance impact of my change
  • I have checked that my change did not significantly increase bundle size
  • I am exporting any new components or constants in the index.js in the component directory
  • I am exporting any new components or constants in the index.js in the root

🔮 Next Steps

📷 Screenshots / GIFs

Before:
image

After:
image

@github-actions
Copy link

✔️ Deploy Preview ready!
😎 Browse the preview: https://vue.dialpad.design/deploy-previews/pr-1171/
🔨 If you experience an SSL issue then wait 2 minutes and try again.

@iropolo
Copy link
Contributor

iropolo commented Sep 13, 2023

Vue2 #1170

iropolo
iropolo approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@iropolo iropolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions github-actions bot added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label Sep 13, 2023
@eabrakov eabrakov merged commit 2f84a6e into staging-vue3 Sep 13, 2023
10 checks passed
@eabrakov eabrakov deleted the fix-avatar-alignment-in-feed-item-vue3 branch September 13, 2023 16:34
iropolo pushed a commit that referenced this pull request Sep 14, 2023
@semantic-release-bot
chore(release): 3.84.0
e152718 
# [3.84.0](v3.83.0...v3.84.0) (2023-09-14)

### Bug Fixes

* **Feed Item,feed Item Row:** fix avatar alignment ([#1171](#1171)) ([2f84a6e](2f84a6e))
* **Image Viewer:** fix close icon not visible on dark mode ([#1169](#1169)) ([7b45537](7b45537))

### Features

* **Leftbar Row:** add new icon color for contact center type ([#1175](#1175)) ([2401063](2401063))
* **Message Input:** add focus method ([#1177](#1177)) ([1e113a4](1e113a4))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iropolo iropolo iropolo approved these changes

@juliodialpad juliodialpad Awaiting requested review from juliodialpad juliodialpad is a code owner

@braddialpad braddialpad Awaiting requested review from braddialpad braddialpad is a code owner

Assignees
No one assigned
Labels
visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eabrakov @iropolo