-
Notifications
You must be signed in to change notification settings - Fork 1
fix(message-input): tooltip should be displayed when character limit has been reached #1280
Conversation
✔️ Deploy Preview ready! |
It's the red -375 in the bottom right. |
Nevermind you meant the tooltip not the number.. Yeah I also can't see it. |
Yes is it not triggering ? |
Oh I see, you actually have to mouseover it, it doesn't show up automatically when you hit the limit |
oh no, it supposed to just show on hover when the user is puzzled why send button is disabled. The disable of send button should be from product side. |
the screenshot is in the ticket showing what the behaviour is: https://dialpad.atlassian.net/browse/DP-81811 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good I think, just one question.
v-if="displayCharacterLimitWarning" | ||
:enabled="characterLimitWarningMessage && (characterLimitCount - inputLength < 0)" | ||
placement="top-end" | ||
:message="characterLimitWarningMessage" | ||
class="d-fc-error d-mr16 d-as-center dt-message-input--remaining-char" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these classes be on the anchor
instead of the tooltip itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i moved everything from
as i had an issue with it showing up. didnt have to move classes. Moved it back.
Yeah makes sense, I just didn't understand the functionality initally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Pre-approving it. (Review Brad's comments please)
Not really your issue, more of a design issue, but wouldn't it make sense for the tooltip to show when hovering the send button rather than the red text then? I know if I was a user I'd likely hover the button rather than the red text |
I will pass on the feedback. i felt the same way too. but then you can argue a disabled send button should not be focusable. |
✔️ Deploy Preview ready! |
It's actually a very common case and we have guidance for it in our docs This definitely doesn't need to hold up this PR but yeah it's a good idea to shoot this question at design I think. It feels a bit off. |
✔️ Deploy Preview ready! |
## [3.93.1](v3.93.0...v3.93.1) (2023-10-27) ### Bug Fixes * date functions locale global ([8fe7307](8fe7307)) * **Message Input:** tooltip should be displayed when character limit has been reached ([#1280](#1280)) ([b5a99cb](b5a99cb)) ### Documentation * document date functions ([#1283](#1283)) ([5efa023](5efa023))
* chore: update storybook to 7.4.2 (#1199) * chore: update storybook to 7.4.2 * add seed to callbox for visual test purposes * chore: update storybook to 7.4.2 (#1200) * chore: update storybook to 7.4.2 * add seed to callbox for visual test purposes * downgrade vitest to 33.0 * add seed for avatar * feat: update dialtone icons to 2.2.0 * chore(release): 2.98.0 # [2.98.0](dialpad/dialtone-vue@v2.97.0...v2.98.0) (2023-09-21) ### Features * update dialtone icons to 2.2.0 ([543b160](dialpad/dialtone-vue@543b160)) * feat: update dialtone icons to 3.2.0 * chore(release): 3.86.0 # [3.86.0](dialpad/dialtone-vue@v3.85.0...v3.86.0) (2023-09-21) ### Bug Fixes * add virtual "prompt" for visual tests on PR ([#1193](dialpad/dialtone-vue#1193)) ([952fd5a](dialpad/dialtone-vue@952fd5a)) * **Avatar:** change avatar seed algorithm to sync with android ([#1185](dialpad/dialtone-vue#1185)) ([2eef1c3](dialpad/dialtone-vue@2eef1c3)) * **Contact Info, Feed Item Row, Item Layout:** alignment issues ([#1187](dialpad/dialtone-vue#1187)) ([04ebc27](dialpad/dialtone-vue@04ebc27)) * **Item Layout:** selected slot alignment ([#1195](dialpad/dialtone-vue#1195)) ([135c3c0](dialpad/dialtone-vue@135c3c0)) * **Recipe Callbar Button With Popover:** change event name and sync open state - Vue3 ([#1184](dialpad/dialtone-vue#1184)) ([13a6f35](dialpad/dialtone-vue@13a6f35)) ### Features * **Avatar:** add clickable behavior - vue3 ([#1188](dialpad/dialtone-vue#1188)) ([f63ed42](dialpad/dialtone-vue@f63ed42)) * **Callbox:** add clickable behavior - vue3 ([#1197](dialpad/dialtone-vue#1197)) ([3921e37](dialpad/dialtone-vue@3921e37)) * update dialtone icons to 3.2.0 ([b069176](dialpad/dialtone-vue@b069176)) * chore: add nina * chore: add nina * chore: remove jose * fix(contact-row): add space between presence and status text (#1198) * fix(contact-row): add space between presence and status text (#1198) * chore(release): 3.86.1 ## [3.86.1](dialpad/dialtone-vue@v3.86.0...v3.86.1) (2023-09-22) ### Bug Fixes * **Contact Row:** add space between presence and status text ([#1198](dialpad/dialtone-vue#1198)) ([5ad6215](dialpad/dialtone-vue@5ad6215)) * chore(modal): export modal banner kinds (#1205) Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> * chore(modal): export modal banner kinds (#1206) Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> * chore(release): 2.98.1 ## [2.98.1](dialpad/dialtone-vue@v2.98.0...v2.98.1) (2023-09-25) ### Bug Fixes * **Contact Row:** add space between presence and status text ([#1198](dialpad/dialtone-vue#1198)) ([5d26b6d](dialpad/dialtone-vue@5d26b6d)) * Revert "chore(modal): export modal banner kinds" (#1207) * Revert "chore(modal): export modal banner kinds" * fix(modal): export modal banner kinds --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> * fix(modal): export modal banner kinds (#1208) * fix(modal): export modal banner kinds --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> * chore(release): 3.86.2 ## [3.86.2](dialpad/dialtone-vue@v3.86.1...v3.86.2) (2023-09-25) ### Bug Fixes * **Modal:** export modal banner kinds ([#1208](dialpad/dialtone-vue#1208)) ([663090f](dialpad/dialtone-vue@663090f)) * fix(callbox): video height (#1210) * fix(callbox): video height * fix issue * fix(callbox): video height (#1211) * fix(callbox): video height * fix issue * chore(release): 2.98.2 ## [2.98.2](dialpad/dialtone-vue@v2.98.1...v2.98.2) (2023-09-26) ### Bug Fixes * **Callbox:** video height ([#1210](dialpad/dialtone-vue#1210)) ([a51e5cc](dialpad/dialtone-vue@a51e5cc)) * chore(release): 3.86.3 ## [3.86.3](dialpad/dialtone-vue@v3.86.2...v3.86.3) (2023-09-26) ### Bug Fixes * **Callbox:** video height ([#1211](dialpad/dialtone-vue#1211)) ([ceaf1f4](dialpad/dialtone-vue@ceaf1f4)) * fix: emoji row css (#1190) * fix: emoji row css * painfully convert styling * fix events in story * address css pr comments * fix: emoji row css vue3 (#1191) * fix: emoji row css * painfully convert styling * fix events in story * address css pr comments * test(popover, presence, radio): new test template (#1201) * test(popover, presence, radio): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> * test(popover, presence, radio): new test template - vue3 (#1202) * test(popover, presence, radio): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> * test(radio-group, rich-text-editor, root-layout): new test template (#1203) * test(radio-group, rich-text-editor, root-layout): new test template Co-authored-by: iropolo <ignacio.ropolo@visma.com> * test(radio-group, root-layout, scroller): new test template - vue3 (#1204) * test(radio-group, root-layout, scroller): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@visma.com> * fix: emoji picker to trigger emoji plugin with insertContent node (#1220) * fix(list-item): apply correct color design tokens (#1221) * use muted "action" design token * set default "action" bg color * fix(list-item): apply correct color design tokens - vue3 (#1223) * use muted "action" design token * set default "action" bg color --------- Co-authored-by: Francis Rupert <francisrupert@gmail.com> * fix(callbox, avatar): events and styling (#1218) * fix: remove stop event modifier * fix(callbox): change to underline on title hover * docs(callbox): update examples to use dt-stack * add emit to callbox * update dialtone * update button kinds * center icons horizontally * fix(callbox, avatar): events and styling (#1219) * fix: remove stop event modifier * fix(callbox): change to underline on title hover * docs(callbox): update examples to use dt-stack * update dialtone * add emit to callbox * update button kinds * center icons horizontally * remove click event * chore(release): 2.98.3 ## [2.98.3](dialpad/dialtone-vue@v2.98.2...v2.98.3) (2023-09-28) ### Bug Fixes * **Callbox, Avatar:** events and styling ([#1218](dialpad/dialtone-vue#1218)) ([e17fd36](dialpad/dialtone-vue@e17fd36)) * emoji row css ([#1190](dialpad/dialtone-vue#1190)) ([a11147a](dialpad/dialtone-vue@a11147a)) * **List Item:** apply correct color design tokens ([#1221](dialpad/dialtone-vue#1221)) ([e1f5e32](dialpad/dialtone-vue@e1f5e32)) * chore(release): 3.86.4 ## [3.86.4](dialpad/dialtone-vue@v3.86.3...v3.86.4) (2023-09-28) ### Bug Fixes * **Callbox, Avatar:** events and styling ([#1219](dialpad/dialtone-vue#1219)) ([5875cf9](dialpad/dialtone-vue@5875cf9)) * emoji picker to trigger emoji plugin with insertContent node ([#1220](dialpad/dialtone-vue#1220)) ([5d35041](dialpad/dialtone-vue@5d35041)) * emoji row css vue3 ([#1191](dialpad/dialtone-vue#1191)) ([1b68b87](dialpad/dialtone-vue@1b68b87)) * **List Item:** apply correct color design tokens - vue3 ([#1223](dialpad/dialtone-vue#1223)) ([ed2e786](dialpad/dialtone-vue@ed2e786)) * feat(callbox): on hold status (#1225) * feat(callbox): on hold status * update docs * feat(callbox): on hold status (#1226) * feat(callbox): on hold status * update docs * chore(release): 2.99.0 # [2.99.0](dialpad/dialtone-vue@v2.98.3...v2.99.0) (2023-09-29) ### Features * **Callbox:** on hold status ([#1225](dialpad/dialtone-vue#1225)) ([fd5963a](dialpad/dialtone-vue@fd5963a)) * chore(release): 3.87.0 # [3.87.0](dialpad/dialtone-vue@v3.86.4...v3.87.0) (2023-09-29) ### Features * **Callbox:** on hold status ([#1226](dialpad/dialtone-vue#1226)) ([8f5e1bd](dialpad/dialtone-vue@8f5e1bd)) * chore(release): 3.87.0 # [3.87.0](dialpad/dialtone-vue@v3.86.4...v3.87.0) (2023-09-29) ### Features * **Callbox:** on hold status ([#1226](dialpad/dialtone-vue#1226)) ([8f5e1bd](dialpad/dialtone-vue@8f5e1bd)) * fix: address feedItemRow and feedItemPill css issues vue3 (#1224) * fix: address feedItemRow and feedItemPill css issues vue3 * missed a code reuse spot * expose avatar seed as a prop * address PR comments * fix: address feedItemRow and feedItemPill css issues (#1215) * fix: address feedItemRow and feedItemPill css issues * missed a code reuse spot * expose avatar seed as a prop * address PR comments * test(select-menu, skeleton, stack): new test template (#1217) * test(select-menu, skeleton, stack): export modal banner kinds --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> * test(select-menu, skeleton, stack): new test template - vue3 (#1216) * test(select-menu, skeleton, stack): export modal banner kinds --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> * fix(root-layout): remove fixed height on header/footer * Revert "fix(root-layout): remove fixed height on header/footer" This reverts commit c91e982. * docs(stack): add new defaults for alignment (#1229) * docs(stack): add new defaults for alignment * update dialtone dependency * docs(stack): add new defaults for alignment - vue3 (#1230) * docs(stack): add new defaults for alignment * update dialtone dependency * chore: add release script (#1227) * chore: add release script (#1228) * fix(root-layout): remove fixed height on header/footer (#1231) * fix(root-layout): remove fixed height on header/footer This reverts commit 5a212df. * fix tests * fix(root-layout): remove fixed height on header/footer (#1236) * fix(root-layout): remove fixed height on header/footer This reverts commit 5a212df. * fix tests * chore(release): 3.87.1 ## [3.87.1](dialpad/dialtone-vue@v3.87.0...v3.87.1) (2023-10-04) ### Bug Fixes * address feedItemRow and feedItemPill css issues vue3 ([#1224](dialpad/dialtone-vue#1224)) ([aa08b34](dialpad/dialtone-vue@aa08b34)) * **Root Layout:** remove fixed height on header/footer ([#1231](dialpad/dialtone-vue#1231)) ([3a6d9af](dialpad/dialtone-vue@3a6d9af)) ### Documentation * **Stack:** add new defaults for alignment - vue3 ([#1230](dialpad/dialtone-vue#1230)) ([beb8baf](dialpad/dialtone-vue@beb8baf)) * chore(release): 2.99.1 ## [2.99.1](dialpad/dialtone-vue@v2.99.0...v2.99.1) (2023-10-04) ### Bug Fixes * address feedItemRow and feedItemPill css issues ([#1215](dialpad/dialtone-vue#1215)) ([69fd69f](dialpad/dialtone-vue@69fd69f)) * **Root Layout:** remove fixed height on header/footer ([#1236](dialpad/dialtone-vue#1236)) ([8e575b0](dialpad/dialtone-vue@8e575b0)) ### Documentation * **Stack:** add new defaults for alignment ([#1229](dialpad/dialtone-vue#1229)) ([11cfb62](dialpad/dialtone-vue@11cfb62)) * fix: alignment for emoji and emoji row (#1232) * fix: alignment for emoji and emoji row * fix: alignment for emoji and emoji row - vue3 (#1233) * fix: alignment for emoji and emoji row * feat: update dialtone-icons * chore(release): 3.88.0 # [3.88.0](dialpad/dialtone-vue@v3.87.1...v3.88.0) (2023-10-05) ### Bug Fixes * alignment for emoji and emoji row - vue3 ([#1233](dialpad/dialtone-vue#1233)) ([53d7fa6](dialpad/dialtone-vue@53d7fa6)) ### Features * update dialtone-icons ([52a3c92](dialpad/dialtone-vue@52a3c92)) * feat: update dialtone-icons * chore(release): 2.100.0 # [2.100.0](dialpad/dialtone-vue@v2.99.1...v2.100.0) (2023-10-05) ### Bug Fixes * alignment for emoji and emoji row ([#1232](dialpad/dialtone-vue#1232)) ([8a9afad](dialpad/dialtone-vue@8a9afad)) ### Features * update dialtone-icons ([92d5498](dialpad/dialtone-vue@92d5498)) * docs: fix avatar images broken (#1234) * docs: fix avatar images broken * fix a11ty test * remove unused image * docs: fix avatar images broken (#1235) * docs: fix avatar images broken * fix a11ty test * vue 3 migration * remove unused image * fix(breadcrumbs): fix story configuration of BreadcrumbItem (#1246) * fix: href on link * fix(breadcrumbs): fix story configuration of BreadcrumbItem * fix whitespace * correct url -> href * Revert "fix: href on link" This reverts commit 5db2f406db0ffb7160151c320f8b096607ce4390. * fix markdown lint --------- Co-authored-by: Sanjeev Suresh <ssuresh@dialpad.com> * fix(breadcrumbs): fix story configuration of BreadcrumbItem (#1247) * fix: href on link * fix(breadcrumbs): fix story configuration of BreadcrumbItem * fix whitespace * Revert "fix: href on link" This reverts commit 62d940a04f577b15788cb8bf57047ef5b52e6d5f. * correct url -> href * fix markdown lint --------- Co-authored-by: Sanjeev Suresh <ssuresh@dialpad.com> * fix(general-row): set voice chat icon to waveform * fix(general-row): set voice chat icon to waveform * test(tab, tab-panel, toast): new test template (#1240) * test(tab, tab-panel, toast): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> * test(tab, tab-panel, toast): new test template - vue3 (#1241) * test(tab, tab-panel, toast): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> * docs(avatar): missing examples (#1238) * docs(avatar): add missing group examples * prevent duplicated key * docs(avatar): add missing group examples (#1239) * fix: href on link (#1244) * fix: href on link (#1245) Co-authored-by: Brad Paugh <brad.paugh@dialpad.com> * fix(callbar-button): slot not working (#1242) * fix(callbar-button): slot not working * fix attribute inheritance * add event object to emit * fix attrs inheritance * move events to button * fix broken tests * fix(callbar-button): slot not working (#1243) * fix(callbar-button): slot not working * clean up * fix attribute inheritance * fix attrs inheritance * move events to button * fix broken tests * test(toggle, tooltip, validation-messages): new test template (#1249) * test(toggle, tooltip, validation-messages): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> * test(toggle, tooltip, validation-messages): new test template - vue3 (#1250) * test(toggle, tooltip, validation-messages): new test template --------- Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> * fix(root-layout): use inner child width for sidebar (#1251) * fix(root-layout): use inner child width for sidebar * set 100p * docs * fix(root-layout): use inner child width for sidebar (#1252) * fix(root-layout): use inner child width for sidebar * set 100p * docs * chore(release): 2.100.1 ## [2.100.1](dialpad/dialtone-vue@v2.100.0...v2.100.1) (2023-10-06) ### Bug Fixes * **Breadcrumbs:** fix story configuration of BreadcrumbItem ([#1246](dialpad/dialtone-vue#1246)) ([3ce325d](dialpad/dialtone-vue@3ce325d)) * **Callbar Button:** slot not working ([#1242](dialpad/dialtone-vue#1242)) ([0b5d67f](dialpad/dialtone-vue@0b5d67f)) * **General Row:** set voice chat icon to waveform ([3812434](dialpad/dialtone-vue@3812434)) * href on link ([#1244](dialpad/dialtone-vue#1244)) ([9245081](dialpad/dialtone-vue@9245081)) * **Root Layout:** use inner child width for sidebar ([#1251](dialpad/dialtone-vue#1251)) ([9e55f6f](dialpad/dialtone-vue@9e55f6f)) ### Documentation * **Avatar:** missing examples ([#1238](dialpad/dialtone-vue#1238)) ([163ab02](dialpad/dialtone-vue@163ab02)) * fix avatar images broken ([#1234](dialpad/dialtone-vue#1234)) ([d90d890](dialpad/dialtone-vue@d90d890)) * chore(release): 3.88.1 ## [3.88.1](dialpad/dialtone-vue@v3.88.0...v3.88.1) (2023-10-06) ### Bug Fixes * **Breadcrumbs:** fix story configuration of BreadcrumbItem ([#1247](dialpad/dialtone-vue#1247)) ([9794cf4](dialpad/dialtone-vue@9794cf4)) * **Callbar Button:** slot not working ([#1243](dialpad/dialtone-vue#1243)) ([8138fd3](dialpad/dialtone-vue@8138fd3)) * **General Row:** set voice chat icon to waveform ([4bc6d6c](dialpad/dialtone-vue@4bc6d6c)) * href on link ([#1245](dialpad/dialtone-vue#1245)) ([9cd2c25](dialpad/dialtone-vue@9cd2c25)) * **Root Layout:** use inner child width for sidebar ([#1252](dialpad/dialtone-vue#1252)) ([6b4cc41](dialpad/dialtone-vue@6b4cc41)) ### Documentation * **Avatar:** add missing group examples ([#1239](dialpad/dialtone-vue#1239)) ([d7b313a](dialpad/dialtone-vue@d7b313a)) * fix avatar images broken ([#1235](dialpad/dialtone-vue#1235)) ([8ec0975](dialpad/dialtone-vue@8ec0975)) * chore: update storybook * chore: update storybook * feat(rich-text-editor): contact mentions (#1248) * fix(root-layout): convert to pure CSS grid method (#1253) * fix(root-layout): convert to pure CSS grid method * separate classes * fix storybook booleans * fix test * map fixed prop correctly * remove sidebar sticky * fix(root-layout): convert to pure CSS grid method (#1254) * fix(root-layout): convert to pure CSS grid method * separate classes * fix storybook booleans * fix test * map fixed prop correctly * remove sidebar sticky * chore(release): 3.89.0 # [3.89.0](dialpad/dialtone-vue@v3.88.1...v3.89.0) (2023-10-13) ### Bug Fixes * **Root Layout:** convert to pure CSS grid method ([#1254](dialpad/dialtone-vue#1254)) ([3dbd0be](dialpad/dialtone-vue@3dbd0be)) ### Features * **Rich Text Editor:** contact mentions ([#1248](dialpad/dialtone-vue#1248)) ([19a99fb](dialpad/dialtone-vue@19a99fb)) * feat(dt-recipe-ivr-node): change z-index and docs (#1258) * feat(dt-recipe-ivr-node): change z-index and docs (#1257) * chore(release): 2.101.0 # [2.101.0](dialpad/dialtone-vue@v2.100.1...v2.101.0) (2023-10-16) ### Bug Fixes * **Root Layout:** convert to pure CSS grid method ([#1253](dialpad/dialtone-vue#1253)) ([db3ba06](dialpad/dialtone-vue@db3ba06)) ### Features * **Dt Recipe Ivr Node:** change z-index and docs ([#1257](dialpad/dialtone-vue#1257)) ([1d5c703](dialpad/dialtone-vue@1d5c703)) * chore(release): 3.90.0 # [3.90.0](dialpad/dialtone-vue@v3.89.0...v3.90.0) (2023-10-16) ### Features * **Dt Recipe Ivr Node:** change z-index and docs ([#1258](dialpad/dialtone-vue#1258)) ([d9b4559](dialpad/dialtone-vue@d9b4559)) * feat: attachment carousel for generic media files (#1209) * fix(radio, checkbox): apply fieldset class (#1259) * fix(radio, checkbox): apply fieldset class * fix wrapper display * correct structure * fix input decorator * fix(radio, checkbox): apply fieldset class (#1260) * fix(radio, checkbox): apply fieldset class * fix wrapper display * correct structure * fix input decorator * chore(release): 2.101.1 ## [2.101.1](dialpad/dialtone-vue@v2.101.0...v2.101.1) (2023-10-16) ### Bug Fixes * **Radio, Checkbox:** apply fieldset class ([#1259](dialpad/dialtone-vue#1259)) ([61a6899](dialpad/dialtone-vue@61a6899)) * chore(root-layout): remove css from component (#1262) * chore(root-layout): remove css from component (#1263) * fix: click event on leftbar group row (#1265) * chore(release): 3.91.0 # [3.91.0](dialpad/dialtone-vue@v3.90.0...v3.91.0) (2023-10-19) ### Bug Fixes * click event on leftbar group row ([#1265](dialpad/dialtone-vue#1265)) ([d31bf5d](dialpad/dialtone-vue@d31bf5d)) * **Radio, Checkbox:** apply fieldset class ([#1260](dialpad/dialtone-vue#1260)) ([7e2f0f6](dialpad/dialtone-vue@7e2f0f6)) ### Features * attachment carousel for generic media files ([#1209](dialpad/dialtone-vue#1209)) ([ef195ae](dialpad/dialtone-vue@ef195ae)) * fix: suggestion list CSS changes (#1255) * feat(dt-tooltip-directive): add dt-tooltip directive (#1256) * working example * working with duplicated tooltips * feat(tooltip): external anchor * feat(tooltip-directive): create directive * fix unit tests * fix action panel * fix warning * fix reactivity issues * add docs * add tests * standarized with vue 3 * hide controls panel * use global show * update percy dependencies * feat(dt-tooltip-directive): add dt-tooltip directive (#1264) * working example * working with duplicated tooltips * feat(tooltip): external anchor * feat(tooltip-directive): create directive * fix unit tests * fix action panel * fix warning * fix reactivity issues * add docs * add tests * migrate to vue 3 * fix tests * fix a11y tests * fix a11y tests * hide controls panel * use global show * update percy dependencies * feat: add avatar slot to feed-item-row (#1266) * feat: add avatar slot to feed-item-row * Update recipes/conversation_view/feed_item_row/feed_item_row_default.story.vue Co-authored-by: Julio Ortega <julio.ortega@dialpad.com> --------- Co-authored-by: Julio Ortega <julio.ortega@dialpad.com> * feat: add avatar slot to feed-item-row (#1267) * feat: add avatar slot to feed-item-row * $attrs * Update recipes/conversation_view/feed_item_row/feed_item_row_default.story.vue Co-authored-by: Julio Ortega <julio.ortega@dialpad.com> --------- Co-authored-by: Julio Ortega <julio.ortega@dialpad.com> * feat: update dialtone-icons * feat: update dialtone-icons * chore(release): 3.92.0 # [3.92.0](dialpad/dialtone-vue@v3.91.0...v3.92.0) (2023-10-20) ### Bug Fixes * suggestion list CSS changes ([#1255](dialpad/dialtone-vue#1255)) ([abd4735](dialpad/dialtone-vue@abd4735)) ### Features * add avatar slot to feed-item-row ([#1267](dialpad/dialtone-vue#1267)) ([1cc8b71](dialpad/dialtone-vue@1cc8b71)) * **Dt Tooltip Directive:** add dt-tooltip directive ([#1264](dialpad/dialtone-vue#1264)) ([6a67cae](dialpad/dialtone-vue@6a67cae)) * update dialtone-icons ([11a4714](dialpad/dialtone-vue@11a4714)) * chore(release): 2.102.0 # [2.102.0](dialpad/dialtone-vue@v2.101.1...v2.102.0) (2023-10-20) ### Features * add avatar slot to feed-item-row ([#1266](dialpad/dialtone-vue#1266)) ([c457b28](dialpad/dialtone-vue@c457b28)) * **Dt Tooltip Directive:** add dt-tooltip directive ([#1256](dialpad/dialtone-vue#1256)) ([f67c0cf](dialpad/dialtone-vue@f67c0cf)) * update dialtone-icons ([81ad182](dialpad/dialtone-vue@81ad182)) * fix: export directives in production build (#1270) * fix: export directives in production build * include in tsconfig * fix: export directives in production build (#1271) * fix: export directives in production build * include in tsconfig * chore(release): 2.102.1 ## [2.102.1](dialpad/dialtone-vue@v2.102.0...v2.102.1) (2023-10-20) ### Bug Fixes * export directives in production build ([#1270](dialpad/dialtone-vue#1270)) ([78c5e2d](dialpad/dialtone-vue@78c5e2d)) * chore(release): 3.92.1 ## [3.92.1](dialpad/dialtone-vue@v3.92.0...v3.92.1) (2023-10-20) ### Bug Fixes * export directives in production build ([#1271](dialpad/dialtone-vue#1271)) ([b34febb](dialpad/dialtone-vue@b34febb)) * fix(button): icon sizing (#1268) * fix(button): icon sizing (#1269) * fix(dt-tooltip-directive): default delay (#1272) * fix(dt-tooltip-directive): default delay * cleanup * fix tests * minor fix * fix(dt-tooltip-directive): default delay (#1273) * fix(dt-tooltip-directive): default delay * fix tests * fix tests * fix: add disabled prop to tooltip (#1276) * fix: add disabled prop to tooltip - vue3 (#1277) * feat(call-pill): add default toggled state (#1261) * feat(call-pill): add default toggled state * fix(feed_item_pill): remove DT utils & cleanup * doc(feed_item_pill): update toggled wording * docs(feed_item_pill): move base style order Why: - Closer to the control - Reactive with the controls * feat(DtRecipeFeedItemPill): add variants template * feat(DtRecipeFeedItemPill): remove default from variants * docs(DtRecipeFeedItemPill): update story params * feat(DtRecipeFeedItemPill): allow title template * docs(DtRecipeFeedItemCall): update call/meeting w/recap Calls/meetings with recaps have the gradient ai as the color of the pill border. * add Feed item pill: default story to percy exclusions. --------- Co-authored-by: Julio Ortega <julio.ortega@dialpad.com> * feat(call-pill): add default toggled state - vue3 (#1275) * feat(call-pill): add default toggled state * fix(feed_item_pill): remove DT utils & cleanup * doc(feed_item_pill): update toggled wording * docs(feed_item_pill): move base style order Why: - Closer to the control - Reactive with the controls * feat(DtRecipeFeedItemPill): add variants template * feat(DtRecipeFeedItemPill): remove default from variants * docs(DtRecipeFeedItemPill): update story params * feat(DtRecipeFeedItemPill): allow title template * docs(DtRecipeFeedItemCall): update call/meeting w/recap Calls/meetings with recaps have the gradient ai as the color of the pill border. * add Feed item pill: default story to percy exclusions. * docs(DtRecipeFeedItemPill): fix vue3 nits --------- Co-authored-by: Julio Ortega <julio.ortega@dialpad.com> * feat: add initial date formatting functions (#1278) * feat: add initial date formatting functions * add export * add japanese capitalization test * cleanup dateRelativeToNow * update function names to be more generic * feat: add initial date formatting functions (#1279) * feat: add initial date formatting functions * add export * add japanese capitalization test * cleanup dateRelativeToNow * update function names to be more generic * chore: update dialtone * chore(release): 2.103.0 # [2.103.0](dialpad/dialtone-vue@v2.102.1...v2.103.0) (2023-10-25) ### Bug Fixes * add disabled prop to tooltip ([#1276](dialpad/dialtone-vue#1276)) ([dce2730](dialpad/dialtone-vue@dce2730)) * **Button:** icon sizing ([#1268](dialpad/dialtone-vue#1268)) ([ae6e390](dialpad/dialtone-vue@ae6e390)) * **Dt Tooltip Directive:** default delay ([#1272](dialpad/dialtone-vue#1272)) ([773b148](dialpad/dialtone-vue@773b148)) ### Features * add initial date formatting functions ([#1278](dialpad/dialtone-vue#1278)) ([ce6c6e7](dialpad/dialtone-vue@ce6c6e7)) * **Call Pill:** add default toggled state ([#1261](dialpad/dialtone-vue#1261)) ([a9cfda3](dialpad/dialtone-vue@a9cfda3)) * chore: update dialtone * chore(release): 3.93.0 # [3.93.0](dialpad/dialtone-vue@v3.92.1...v3.93.0) (2023-10-25) ### Bug Fixes * add disabled prop to tooltip - vue3 ([#1277](dialpad/dialtone-vue#1277)) ([e25a755](dialpad/dialtone-vue@e25a755)) * **Button:** icon sizing ([#1269](dialpad/dialtone-vue#1269)) ([ec0df97](dialpad/dialtone-vue@ec0df97)) * **Dt Tooltip Directive:** default delay ([#1273](dialpad/dialtone-vue#1273)) ([5c65241](dialpad/dialtone-vue@5c65241)) ### Features * add initial date formatting functions ([#1279](dialpad/dialtone-vue#1279)) ([f8340e9](dialpad/dialtone-vue@f8340e9)) * **Call Pill:** add default toggled state - vue3 ([#1275](dialpad/dialtone-vue#1275)) ([c4afed8](dialpad/dialtone-vue@c4afed8)) * fix(message-input): tooltip should be displayed when character limit has been reached (#1280) * docs: document date functions (#1282) * docs: document date functions * move doc functions to storybook build command * docs: document date functions (#1283) * docs: document date functions * move doc functions to storybook build command * fix: date functions locale global * fix: date functions locale global * chore(release): 2.103.1 ## [2.103.1](dialpad/dialtone-vue@v2.103.0...v2.103.1) (2023-10-27) ### Bug Fixes * date functions locale global ([2400feb](dialpad/dialtone-vue@2400feb)) ### Documentation * document date functions ([#1282](dialpad/dialtone-vue#1282)) ([d3d9b54](dialpad/dialtone-vue@d3d9b54)) * chore(release): 3.93.1 ## [3.93.1](dialpad/dialtone-vue@v3.93.0...v3.93.1) (2023-10-27) ### Bug Fixes * date functions locale global ([8fe7307](dialpad/dialtone-vue@8fe7307)) * **Message Input:** tooltip should be displayed when character limit has been reached ([#1280](dialpad/dialtone-vue#1280)) ([b5a99cb](dialpad/dialtone-vue@b5a99cb)) ### Documentation * document date functions ([#1283](dialpad/dialtone-vue#1283)) ([5efa023](dialpad/dialtone-vue@5efa023)) * docs: update root layout examples (#1285) * docs: update root layout examples * remove color from footer slot * add tabindex=0 on scrollable region * docs: update root layout examples (#1286) * docs: update root layout examples * package lock * remove color from footer slot * add tabindex=0 on scrollable region * fix: fix time stamp being too low vue3 (#1284) * fix: fix time stamp being too low (#1281) * docs: fixed story for buttongroup component aligment (#1287) * docs: fixed story for buttongroup component aligment * docs: fixed v-if-else in button group story * docs: fixed story for button-group component alignment vue3 version (#1288) * docs: fixed story for buttongroup component aligment * docs: fixed v-if-else in button group story * chore: createTemplateFromVueFile same signature as vue 2 branch * chore: revert createTemplateFromVueFile same signature as vue 2 branch This reverts commit 50d2c6d. * chore: createTemplateFromVueFile same signature as vue 2 branch This reverts commit 2f5fd05. * feat: add description list component (#1289) * feat: add description list component * feat: add description list component vue 3 (#1291) * feat: add description list component * fix: max height for content editable (#1293) * chore: add $attrs to vue2 (#1292) * refactor(icon): update dialtone icons usage (#1295) * refactor: update dialtone icons usage * update dialtone-icons * prevent duplicated keys * fix tests * change to computed prop * fix tests * make dialtone-icons external * move icons to devDependencies and add to peerDependencies * update package-lock.json * externalize all node_modules deps * disable duplicate-id a11y rule * fix icons visual tests * update percy cli * disable cache on test * refactor(icon): update dialtone icons usage (#1294) * refactor: update dialtone icons usage * update dialtone-icons * prevent duplicated keys * move to beforeCreate * fix tests * fix icon reactivity * fix tests * change to computed prop * make dialtone-icons external * move icons to devDependencies and add to peerDependencies * update package-lock.json * externalize all node_modules deps * disable duplicate-id a11y rule * fix icons visual tests * update percy cli * disable cache on test * update package-lock.json * fix: update dialtone-icons version * chore(release): 2.104.0 # [2.104.0](dialpad/dialtone-vue@v2.103.1...v2.104.0) (2023-11-08) ### Bug Fixes * fix time stamp being too low ([#1281](dialpad/dialtone-vue#1281)) ([56fb699](dialpad/dialtone-vue@56fb699)) * update dialtone-icons version ([dca9d2f](dialpad/dialtone-vue@dca9d2f)) ### Code Refactoring * **Icon:** update dialtone icons usage ([#1294](dialpad/dialtone-vue#1294)) ([929bb37](dialpad/dialtone-vue@929bb37)) ### Documentation * fixed story for buttongroup component aligment ([#1287](dialpad/dialtone-vue#1287)) ([3bb170f](dialpad/dialtone-vue@3bb170f)) * update root layout examples ([#1285](dialpad/dialtone-vue#1285)) ([8c59581](dialpad/dialtone-vue@8c59581)) ### Features * add description list component ([#1289](dialpad/dialtone-vue#1289)) ([9ef361b](dialpad/dialtone-vue@9ef361b)) * fix: update dialtone-icons version * chore(release): 3.94.0 # [3.94.0](dialpad/dialtone-vue@v3.93.1...v3.94.0) (2023-11-08) ### Bug Fixes * fix time stamp being too low vue3 ([#1284](dialpad/dialtone-vue#1284)) ([1458f1e](dialpad/dialtone-vue@1458f1e)) * max height for content editable ([#1293](dialpad/dialtone-vue#1293)) ([6695eb6](dialpad/dialtone-vue@6695eb6)) * update dialtone-icons version ([56af5ae](dialpad/dialtone-vue@56af5ae)) ### Code Refactoring * **Icon:** update dialtone icons usage ([#1295](dialpad/dialtone-vue#1295)) ([ab0ce7d](dialpad/dialtone-vue@ab0ce7d)) ### Documentation * fixed story for button-group component alignment vue3 version ([#1288](dialpad/dialtone-vue#1288)) ([fc85c15](dialpad/dialtone-vue@fc85c15)) * update root layout examples ([#1286](dialpad/dialtone-vue#1286)) ([77757a6](dialpad/dialtone-vue@77757a6)) ### Features * add description list component vue 3 ([#1291](dialpad/dialtone-vue#1291)) ([80075c3](dialpad/dialtone-vue@80075c3)) * fix: external dependencies * fix: external dependencies (cherry picked from commit d0cfa67) * chore(release): 2.104.1 ## [2.104.1](dialpad/dialtone-vue@v2.104.0...v2.104.1) (2023-11-08) ### Bug Fixes * external dependencies ([ff0d577](dialpad/dialtone-vue@ff0d577)) * chore(release): 3.94.1 ## [3.94.1](dialpad/dialtone-vue@v3.94.0...v3.94.1) (2023-11-08) ### Bug Fixes * external dependencies ([d0cfa67](dialpad/dialtone-vue@d0cfa67)) * fix: remove dialtone-icons from external deps * fix: remove dialtone-icons from external deps * chore(release): 2.104.2 ## [2.104.2](dialpad/dialtone-vue@v2.104.1...v2.104.2) (2023-11-08) ### Bug Fixes * remove dialtone-icons from external deps ([21ef620](dialpad/dialtone-vue@21ef620)) * chore(release): 3.94.2 ## [3.94.2](dialpad/dialtone-vue@v3.94.1...v3.94.2) (2023-11-08) ### Bug Fixes * remove dialtone-icons from external deps ([01a6ed0](dialpad/dialtone-vue@01a6ed0)) * fix(dt-icon): import default module * chore: increase test timeout * chore: increase test timeout (cherry picked from commit 7c919da) * chore(release): 2.104.3 ## [2.104.3](dialpad/dialtone-vue@v2.104.2...v2.104.3) (2023-11-08) ### Bug Fixes * **Dt Icon:** import default module ([02e4c56](dialpad/dialtone-vue@02e4c56)) * fix: select events * chore(release): 3.94.3 ## [3.94.3](dialpad/dialtone-vue@v3.94.2...v3.94.3) (2023-11-10) ### Bug Fixes * select events ([aa10d83](dialpad/dialtone-vue@aa10d83)) * fix: test * chore(release): 3.94.4 ## [3.94.4](dialpad/dialtone-vue@v3.94.3...v3.94.4) (2023-11-10) ### Bug Fixes * test ([6660f18](dialpad/dialtone-vue@6660f18)) * fix: select events * fix: test * docs(tooltip): add sticky popper variation (#1298) * docs(tooltip): add sticky popper variation * fix to exclude from percy * docs(tooltip): add sticky popper variation (#1299) * docs(tooltip): add sticky popper variation * fix to exclude from percy * fix: enter event stop propagation on suggestion list (#1301) * docs: fix not working stories (#1302) * docs: fix not working stories (#1303) * feat(message-input): edit message mode using the same recipe (#1306) * feat: upgrade vite to v5 and node to v20 (#1309) * feat: upgrade vite to v5 and node to v20 * revert vitest * update dialtone 8.21.4 * chore(release): 3.95.0 # [3.95.0](dialpad/dialtone-vue@v3.94.4...v3.95.0) (2023-11-17) ### Bug Fixes * enter event stop propagation on suggestion list ([#1301](dialpad/dialtone-vue#1301)) ([82cd466](dialpad/dialtone-vue@82cd466)) ### Documentation * fix not working stories ([#1303](dialpad/dialtone-vue#1303)) ([149d658](dialpad/dialtone-vue@149d658)) * **Tooltip:** add sticky popper variation ([#1299](dialpad/dialtone-vue#1299)) ([12f2157](dialpad/dialtone-vue@12f2157)) ### Features * **Message Input:** edit message mode using the same recipe ([#1306](dialpad/dialtone-vue#1306)) ([ff28904](dialpad/dialtone-vue@ff28904)) * upgrade vite to v5 and node to v20 ([#1309](dialpad/dialtone-vue#1309)) ([8f9dad4](dialpad/dialtone-vue@8f9dad4)) * fix: dialbot reference * chore(release): 3.95.1 ## [3.95.1](dialpad/dialtone-vue@v3.95.0...v3.95.1) (2023-11-17) ### Bug Fixes * dialbot reference ([2776d7f](dialpad/dialtone-vue@2776d7f)) * fix(collapsible): use correct transition timing variable (#1305) * dialtone-vue3 setup WIP * add dialtone-vue workspace dependency * chore(tooltip, toast, button): import normalization (#1311) * feat(dp-84718): emit skin tone when selected (#1312) * feat: emits a select-skin-tone event when skin tone is selected so we can do what we want with it * change event name to skin-tone (#1313) --------- Co-authored-by: Brad Paugh <brad.paugh@dialpad.com> * chore(release): 3.96.0 # [3.96.0](dialpad/dialtone-vue@v3.95.1...v3.96.0) (2023-11-20) ### Bug Fixes * **Collapsible:** use correct transition timing variable ([#1305](dialpad/dialtone-vue#1305)) ([a8019f3](dialpad/dialtone-vue@a8019f3)) ### Features * **Dp 84718:** emit skin tone when selected ([#1312](dialpad/dialtone-vue#1312)) ([9df6c64](dialpad/dialtone-vue@9df6c64)), closes [#1313](dialpad/dialtone-vue#1313) * remove dialtone-vue2 * fix: npm run lint not detecting errors (#1317) * fix: npm run lint not detecting errors * correct vue3 branch issues * WIP - separate storybook * cleanup * fix issues * update docs * add gitignore * fix issues * change site url * WIP - GCP setup * update package-lock * remove concurrency * checkout repo * remove gcp-auth needs * testing * fix issues * add cache * add needs * add steps * testing * fix JSONs * fix JSONs * test * update filter outputs * test variable name * remove unneeded jobs * fix variable parsing * fix variable parsing * fix variable parsing * trying * setup GCP auth * setup permissions * test gcloud * remove dialtone build * check env * test branch * list bucket contents * testing * testing * test * fix error * test * fix octokit * testing gcloud info * list bucket contents * testing * testing * testing * test token_format * test removing secrets * testing complete workflow * change to secrets and fix error * add dialtone-vue release * fix dialtone-vue deploy * update pnpm-lock.yaml * add dialtone-vue deploy preview * update clean-preview * update permissions --------- Co-authored-by: Brad Paugh <brad.paugh@dialpad.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Ignacio Ropolo <89984179+iropolo@users.noreply.github.com> Co-authored-by: iropolo <ignacio.ropolo@dialpad.com> Co-authored-by: AlexLamDialpad <92543354+AlexLamDialpad@users.noreply.github.com> Co-authored-by: iropolo <ignacio.ropolo@visma.com> Co-authored-by: Sanjeev Suresh <ssuresh@dialpad.com> Co-authored-by: Francis Rupert <francis.rupert@dialpad.com> Co-authored-by: Nina <ninamrepetto@gmail.com> Co-authored-by: Shefali Gupta <shefali.gupta@dialpad.com> Co-authored-by: Fabian Gargaglione <fabian.gargaglione@dialpad.com> Co-authored-by: Yorbi <144369133+yorbi-dp@users.noreply.github.com> Co-authored-by: Cormac Mollitor <cormac.mollitor@dialpad.com>
fix(message-input): Tooltip should be displayed when character limit has been reached
🛠️ Type Of Change
📖 Description
Tooltip showing the character limit message from product should be displayed on the limit count when its negative.