This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
feat(confact-info): add showAvatar and avatarIcon props (Vue3)
#983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonydialpad
requested review from
juliodialpad,
iropolo and
braddialpad
as code owners
13 tasks
|
✔️ Deploy Preview ready! |
|
✔️ Deploy Preview ready! |
juliodialpad
approved these changes
May 18, 2023
tonydialpad
deleted the
DP-70835-add-icon-support-for-avatar-in-contact-info-vue3
branch
braddialpad
pushed a commit
that referenced
this pull request
May 18, 2023
# [3.68.0](v3.67.4...v3.68.0) (2023-05-18) ### Bug Fixes * set node engine minimum ([#989](#989)) ([31daed2](31daed2)) ### Features * **Avatar:** update to flat colors ([#990](#990)) ([12774ea](12774ea)) * **Confact Info:** add `showAvatar` and `avatarIcon` props (Vue3) ([#983](#983)) ([86fed3b](86fed3b))
|
🎉 This PR is included in version 3.68.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Type Of Change
📖 Description
In recent contact update, if the contact has no
first name,last nameorimage_url, the avatar will display nothing. To fix this, this pull request addsavatarIconto support icon display in avatar when there is nothing to display in avatar. Moreover, we want to hide avatar in some use cases, soshowAvatarproperty is added to control that.💡 Context
📝 Checklist
🔮 Next Steps
Make a new release for
dialtone-vue.📷 Screenshots / GIFs
🔗 Sources
JIRA: https://dialpad.atlassian.net/browse/DP-70835
Vue2 PR: #981