Make public stream accessible for logged out users #7775
Conversation
| @@ -17,5 +18,5 @@ | |||
| .loader.hidden | |||
| .spinner | |||
|
|
|||
| - if current_user.contacts.size < 2 | |||
| - if current_user && current_user.contacts.size < 2 | |||
There was a problem hiding this comment.
Use safe navigation (&.) instead of checking if an object exists before calling the method.
There was a problem hiding this comment.
While one could write this as current_user&.contacts&.size&.< 2, I think it's much more readable the way it is now, so I think we can ignore this one.
There was a problem hiding this comment.
I already started working on this one over one and a half year ago, but had problems with what to do with the sidebar so I threw it away again and did other things. The solution with just removing the sidebar completely and center the stream actually looks quiet good 👍 (I have no idea why I didn't just do the same back then ;) )
| @@ -17,5 +18,5 @@ | |||
| .loader.hidden | |||
| .spinner | |||
|
|
|||
| - if current_user.contacts.size < 2 | |||
| - if current_user && current_user.contacts.size < 2 | |||
There was a problem hiding this comment.
While one could write this as current_user&.contacts&.size&.< 2, I think it's much more readable the way it is now, so I think we can ignore this one.
|
Merged as 01ae004, thanks! 🍪 |
Fixes #6564.