Async loading #7513
Merged
Async loading #7513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
force-pushed
the
async-load
branch
2 times, most recently
from
62ce616
to
e673902
Compare
qndel
reviewed
Nov 9, 2024
glebm
force-pushed
the
async-load
branch
9 times, most recently
from
e8591be
to
fa3b52a
Compare
glebm
force-pushed
the
async-load
branch
3 times, most recently
from
be37c9e
to
04f0fb0
Compare
glebm
force-pushed
the
async-load
branch
3 times, most recently
from
8f4e8af
to
c41a9e9
Compare
Does the loading on a separate thread, so we're now loading while fading in and while updating the progress bar.
|
Hail Marry! (don't have time to fully review, but it's a good time for me to test it with others) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the loading on a separate thread, so we're now loading while fading in and while updating the progress bar (resulting in much faster loads; fade outs still happen only after loading).
I had to separate the virtual gamepad surface and texture (de)initialization code because it was logging error messages, and upon further investigation I learned that per https://wiki.libsdl.org/SDL3/CategoryRender:
I also had to adjust fatal error reporting:
app_fatalcan only be called from the main thread, so during loading we instead propagate atl::expectedand send a custom message to the main thread if there is an error. IntroducesRETURN_IF_ERRORandASSIGN_OR_RETURNmacros for more ergonomic status propagation.I think I found most of the places where we currently call
app_fatalduring load and replaced them withtl::expectedpropagation. If I missed any, we won't see an error dialog for these errors and the loading process will appear to hang with lots of console spam instead.Also adds an advanced (ini-only) setting to skip showing loading screen on fast loads. This is what it looks like on my machine with the threshold set to 500ms.
vokoscreenNG-2024-11-09_22-29-53.mp4