Fix pathfinding #7522
Draft
Fix pathfinding #7522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephphatha
reviewed
Nov 10, 2024
ephphatha
reviewed
Nov 10, 2024
glebm
force-pushed
the
path-fix
branch
7 times, most recently
from
ec0c46d
to
d8360c2
Compare
The previous implementation didn't behave quite like A-* is supposed to. After trying to figure out what's causing it and giving up, I've reimplemented it in a straightforward manner. Now it seems to work a lot better.
|
Does this PR also fix #6103 ? |
|
Probably not, this fixes the pathfinding algorithm but doesn't change how stuns are handled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation didn't behave quite like A-* is supposed to.
After trying to figure out what's causing it and giving up, I've reimplemented it in a straightforward manner.
Now it seems to work a lot better.
Why draft?