-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] update default db to rs207 reps #215
Conversation
Interesting -- fails with
|
I'm pretty sure these are failing bc of missing dependencies lxml, plotly, and interval. @ctb, I'm not sure how to handle this within tests. I think tests is taking the environment from |
hmm no, they were failing locally bc of missing dependencies, but now that I have those installed, i'm getting the same
and not totally sure why updating the databases would do that. wondering if it's on the sourmash side? |
Is the Python version that created the pickle file the same as the one reading it? |
Oh sorry, it's pickfile not pickle. |
Ok! so downgrading to sourmash 4.2.3 from 4.4.0 fixed the failed tests. I'll post an issue on sourmash repo, not sure what's causing the problem exactly, but this PR is ready for review and merge @ctb! |
Addresses #212 by updating to the GTDB rs207 reps database by default. Notes of potential importance: