Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: fix codecov upload #102

Merged
merged 4 commits into from
Apr 16, 2023
Merged

MRG: fix codecov upload #102

merged 4 commits into from
Apr 16, 2023

Conversation

ctb
Copy link
Member

@ctb ctb commented Apr 16, 2023

codecov switched the mechanism for uploading coverage; see sourmash-bio/sourmash#2567.

fixing as per sourmash-bio/sourmash#2568.

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.53%. Comparing base (28ce2b8) to head (eb33b8e).
Report is 9 commits behind head on latest.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest     #102   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files          15       15           
  Lines         634      634           
=======================================
  Hits          555      555           
  Misses         79       79           
Flag Coverage Δ
python 87.53% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctb
Copy link
Member Author

ctb commented Apr 16, 2023

This looks like it is working, or at least not failing ;). @luizirber any thoughts?

@ctb
Copy link
Member Author

ctb commented Apr 16, 2023

I'm going to merge this so as to fix the daily tests; happy to consider more/better changes!

@ctb ctb merged commit eed2e69 into latest Apr 16, 2023
@ctb ctb deleted the fix/coverage branch April 16, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant