Fix issues with queries that are bigger than 2GB #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are changes done to the BigByteArrayInputStream, that might not be necessary anymore. Should I revert them? |
bigerl
requested changes
Sep 4, 2024
docs/configuration/big_queries.md
Outdated
Comment on lines
1
to
3
| # Reading Large Queries | ||
|
|
||
| When working with large queries (Queries that are larger than 2^31 Bytes or ~2GB), |
There was a problem hiding this comment.
Suggested change
| # Reading Large Queries | |
| When working with large queries (Queries that are larger than 2^31 Bytes or ~2GB), | |
| # Huge Query Strings | |
| When working with large query strings (longer than 2³² Bytes or ~2GB), |
There was a problem hiding this comment.
I moved the section to the file queries.md.
src/main/java/org/aksw/iguana/commons/io/ByteArrayListInputStream.java
Outdated
Show resolved
Hide resolved
src/main/java/org/aksw/iguana/commons/io/BigByteArrayInputStream.java
Outdated
Show resolved
Hide resolved
src/main/java/org/aksw/iguana/commons/io/BigByteArrayInputStream.java
Outdated
Show resolved
Hide resolved
bigerl
approved these changes
Sep 13, 2024
bigerl
pushed a commit
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.