Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single point version definition #285

Merged
merged 13 commits into from
Oct 19, 2024
Merged

Single point version definition #285

merged 13 commits into from
Oct 19, 2024

Conversation

nck-mlcnv
Copy link
Contributor

@nck-mlcnv nck-mlcnv commented Oct 1, 2024

Versioning:

  • Relocated schema/iguana.owx to src/main/resources/iguana.owx and updated the versionIRI to use the ${revision} placeholder (ontology version will be equal to the version of IGUANA)
  • Updated graalvm/generate-profile.sh to remove hardcoded version numbers and use dynamic naming for instrumented and PGO builds.
  • Added iguana.owx to the resources section in pom.xml for proper inclusion during the build process.

Deployment Workflow Updates:

  • Added steps to reuse artifacts from previous jobs for the ontology

Cleanup

  • Removed old schema images

@nck-mlcnv nck-mlcnv linked an issue Oct 1, 2024 that may be closed by this pull request
@nck-mlcnv nck-mlcnv self-assigned this Oct 1, 2024
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR. Changes look good. There is only the part about independent versioning of IGUANA binaries and ontology.

pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@nck-mlcnv nck-mlcnv requested a review from bigerl October 7, 2024 16:46
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR. Changes look good to me. I just have two small comments.

@nck-mlcnv nck-mlcnv changed the base branch from main to develop October 11, 2024 14:46
# Conflicts:
#	src/main/resources/iguana.owx
@nck-mlcnv nck-mlcnv requested a review from bigerl October 15, 2024 07:03
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Ready to merge.

@nck-mlcnv nck-mlcnv merged commit dd48631 into develop Oct 19, 2024
3 checks passed
@nck-mlcnv nck-mlcnv deleted the fix/versioning branch October 19, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single point of version definition
2 participants