-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-pkgz/expirable-cache to version with generics #109
Conversation
@didip please review this one once you'll have a minute, thanks a lot! |
@paskal per chance, do you notice speed improvements when using the generic version? |
v1, currently in use:
v3 from this PR:
38-42% faster. I did not expect that to happen and did not measure it before you asked me because I never hit the bottlenecks of cache. |
Love it! Thank you for benching it! |
Thanks for the merge! Feel free to release the new version: v7.0.1...95418ad |
v7.0.2 is released. https://github.com/didip/tollbooth/tags |
Instead of assuming the type, it will be set explicitly using generics — no behaviour changes.